diff --git a/sources/JadeitePackageGroupPresenter.cls b/sources/JadeitePackageGroupPresenter.cls index 883d9dee..e9b49649 100644 --- a/sources/JadeitePackageGroupPresenter.cls +++ b/sources/JadeitePackageGroupPresenter.cls @@ -98,6 +98,9 @@ onViewClosed super onViewClosed. BrowserUpdate current removeEventsTriggeredFor: packageGroupPresenter.! +packageGroupPresenter + ^packageGroupPresenter! + packageGroupSelectionChanged self displayPackageGroupPackages! @@ -137,6 +140,7 @@ onDragPackageToComponent:!drag & drop!event handlers!public! ! onDropPackageToComponent:!drag & drop!event handlers!public! ! onDropPackageToPackageGroup:!drag & drop!public! ! onViewClosed!event handlers!public! ! +packageGroupPresenter!accessing!private! ! packageGroupSelectionChanged!event handlers!public! ! queryCommand:!menu handlers!public! ! removePackageFromPackageGroup!menu handlers!public! ! diff --git a/sources/JadeitePackageGroupTestCase.cls b/sources/JadeitePackageGroupTestCase.cls index 7cfc2f7c..a9b707ac 100644 --- a/sources/JadeitePackageGroupTestCase.cls +++ b/sources/JadeitePackageGroupTestCase.cls @@ -26,6 +26,23 @@ test_basicDisplayPackageGroups childNames do: [:childName | self assert: (expectedChildNames includes: childName)]. expectedChildNames do: [:expectedChildName | self assert: (childNames includes: expectedChildName)]! +test_packageGroupEditorSelection + "basic selection was broken" + + | packageGroupEditor | + self testsIssue: #issue923 + withTitle: '(3.2.8) Package Group Editor not implemented sufficiently to have value'. + self selectServiceNamed: 'RowanSample9' in: self projectListPresenter. + packageGroupEditor := self projectsPresenter editPackageGroups. + + [1 to: packageGroupEditor primaryPresenter model packageGroups size + do: + [:index | + packageGroupEditor primaryPresenter packageGroupPresenter selectionByIndex: index. + self assert: packageGroupEditor primaryPresenter packageGroupPresenter selectionByIndex + equals: index]] + ensure: [self destroy: packageGroupEditor]! + test_packageGroupsFromLoadedPackage "in the browser, the package groups shown should be derived from the loaded project, not the project definition." @@ -89,6 +106,7 @@ test_rowanAllPackagesDoesNotTakeTooLong self assert: time < expectedTime! ! !JadeitePackageGroupTestCase categoriesForMethods! test_basicDisplayPackageGroups!public!tests! ! +test_packageGroupEditorSelection!public!tests! ! test_packageGroupsFromLoadedPackage!public!tests! ! test_packageGroupsSelection!public!tests! ! test_rowanAllPackagesDoesNotTakeTooLong!public!tests! !