New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for raw clause parsing #18

Merged
merged 2 commits into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@hanneskaeufler
Contributor

hanneskaeufler commented Oct 12, 2017

This was a bit of fiddling but this exercises the currently uncovered branch as seen here: https://coveralls.io/builds/13692274/source?filename=src%2FCachedBuilder.php#L93

Fixes issue #17

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 12, 2017

Coverage Status

Coverage increased (+0.7%) to 98.561% when pulling af9d8ea on hanneskaeufler:hk-issue-17 into b7a3cc6 on GeneaLabs:master.

coveralls commented Oct 12, 2017

Coverage Status

Coverage increased (+0.7%) to 98.561% when pulling af9d8ea on hanneskaeufler:hk-issue-17 into b7a3cc6 on GeneaLabs:master.

@hanneskaeufler

This comment has been minimized.

Show comment
Hide comment
@hanneskaeufler

hanneskaeufler Oct 12, 2017

Contributor

Scrutinizer failure looked unrelated, so I force pushed to retrigger.

Contributor

hanneskaeufler commented Oct 12, 2017

Scrutinizer failure looked unrelated, so I force pushed to retrigger.

@mikebronner

This comment has been minimized.

Show comment
Hide comment
@mikebronner

mikebronner Oct 12, 2017

Member

@hanneskaeufler Woohoo! :) Thanks for working on this :) It appears the unit tests are failing. Yea, I restarted Scrutinizer, and it passed. Will wait for them to finish, will then merge. Keep the TDD magic going! :)

Member

mikebronner commented Oct 12, 2017

@hanneskaeufler Woohoo! :) Thanks for working on this :) It appears the unit tests are failing. Yea, I restarted Scrutinizer, and it passed. Will wait for them to finish, will then merge. Keep the TDD magic going! :)

@mikebronner mikebronner self-assigned this Oct 12, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 12, 2017

Coverage Status

Coverage increased (+0.7%) to 98.561% when pulling 73de75f on hanneskaeufler:hk-issue-17 into b7a3cc6 on GeneaLabs:master.

coveralls commented Oct 12, 2017

Coverage Status

Coverage increased (+0.7%) to 98.561% when pulling 73de75f on hanneskaeufler:hk-issue-17 into b7a3cc6 on GeneaLabs:master.

@mikebronner mikebronner changed the base branch from master to laravel-5.5 Oct 12, 2017

@mikebronner mikebronner merged commit 8fb0532 into GeneaLabs:laravel-5.5 Oct 12, 2017

4 checks passed

Scrutinizer No new issues
Details
SensioLabsInsight Code quality OK.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.7%) to 98.561%
Details
@hanneskaeufler

This comment has been minimized.

Show comment
Hide comment
@hanneskaeufler

hanneskaeufler Oct 12, 2017

Contributor

Hehe, my pleasure, love me some testing and I almost got nostalgic about php after a few years of no php work lol 💟

Contributor

hanneskaeufler commented Oct 12, 2017

Hehe, my pleasure, love me some testing and I almost got nostalgic about php after a few years of no php work lol 💟

@hanneskaeufler hanneskaeufler deleted the hanneskaeufler:hk-issue-17 branch Oct 12, 2017

@mikebronner

This comment has been minimized.

Show comment
Hide comment
@mikebronner

mikebronner Oct 12, 2017

Member

@hanneskaeufler Make sure you register for Hactoberfest, and if you do the other 3 issues (each as its own pull request), you will already be eligible for your t-shirt! :)

https://hacktoberfest.digitalocean.com

Member

mikebronner commented Oct 12, 2017

@hanneskaeufler Make sure you register for Hactoberfest, and if you do the other 3 issues (each as its own pull request), you will already be eligible for your t-shirt! :)

https://hacktoberfest.digitalocean.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment