From b6e3611636ea97fc20e1bccb14ea269ef5a5170d Mon Sep 17 00:00:00 2001
From: Rodrigo Rodriguez <me@rodrigorodriguez.com>
Date: Thu, 2 Apr 2020 21:24:58 -0300
Subject: [PATCH] fix(core.gbapp): No more empty tests; reference errors fixed.

---
 packages/core.gbapp/tests/core.test.ts        | 10 ----
 packages/core.gbapp/tests/vm.test.ts          | 50 -------------------
 .../dialogs/FeedbackDialog.ts                 |  2 +-
 .../dialogs/QualityDialog.ts                  |  2 +-
 4 files changed, 2 insertions(+), 62 deletions(-)
 delete mode 100644 packages/core.gbapp/tests/core.test.ts
 delete mode 100644 packages/core.gbapp/tests/vm.test.ts

diff --git a/packages/core.gbapp/tests/core.test.ts b/packages/core.gbapp/tests/core.test.ts
deleted file mode 100644
index 00da8ce86..000000000
--- a/packages/core.gbapp/tests/core.test.ts
+++ /dev/null
@@ -1,10 +0,0 @@
-import { expect } from 'chai';
-import { GBImporter } from '../services/GBImporterService';
-
-describe('Hello function', () => {
-  it('should return empty test', () => {
-    const service = new GBImporter(undefined);
-    const result = 0;
-    expect(result).to.equal(0);
-  });
-});
diff --git a/packages/core.gbapp/tests/vm.test.ts b/packages/core.gbapp/tests/vm.test.ts
deleted file mode 100644
index 67ecffeb1..000000000
--- a/packages/core.gbapp/tests/vm.test.ts
+++ /dev/null
@@ -1,50 +0,0 @@
-/*****************************************************************************\
-|                                               ( )_  _                       |
-|    _ _    _ __   _ _    __    ___ ___     _ _ | ,_)(_)  ___   ___     _     |
-|   ( '_`\ ( '__)/'_` ) /'_ `\/' _ ` _ `\ /'_` )| |  | |/',__)/' _ `\ /'_`\   |
-|   | (_) )| |  ( (_| |( (_) || ( ) ( ) |( (_| || |_ | |\__, \| (˅) |( (_) )  |
-|   | ,__/'(_)  `\__,_)`\__  |(_) (_) (_)`\__,_)`\__)(_)(____/(_) (_)`\___/'  |
-|   | |                ( )_) |                                                |
-|   (_)                 \___/'                                                |
-|                                                                             |
-| General Bots Copyright (c) Pragmatismo.io. All rights reserved.             |
-| Licensed under the AGPL-3.0.                                                |
-|                                                                             |
-| According to our dual licensing model, this program can be used either      |
-| under the terms of the GNU Affero General Public License, version 3,        |
-| or under a proprietary license.                                             |
-|                                                                             |
-| The texts of the GNU Affero General Public License with an additional       |
-| permission and of our proprietary license can be found at and               |
-| in the LICENSE file you have received along with this program.              |
-|                                                                             |
-| This program is distributed in the hope that it will be useful,             |
-| but WITHOUT ANY WARRANTY, without even the implied warranty of              |
-| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the                |
-| GNU Affero General Public License for more details.                         |
-|                                                                             |
-| "General Bots" is a registered trademark of Pragmatismo.io.                 |
-| The licensing of the program under the AGPLv3 does not imply a              |
-| trademark license. Therefore any rights, title and interest in              |
-| our trademarks remain entirely with us.                                     |
-|                                                                             |
-\*****************************************************************************/
-
-'use strict';
-
-/**
- * @fileoverview Tests for General Bots VM.
- */
-
-import { expect } from 'chai';
-import { GBVMService } from '../services/GBVMService';
-
-describe('Load function', () => {
-  it('should fail on invalid file', () => {
-    try {
-      const service = new GBVMService();
-    } catch (error) {
-      expect(error).to.equal(0);
-    }
-  });
-});
diff --git a/packages/customer-satisfaction.gbapp/dialogs/FeedbackDialog.ts b/packages/customer-satisfaction.gbapp/dialogs/FeedbackDialog.ts
index 314c9ef48..c469d5123 100644
--- a/packages/customer-satisfaction.gbapp/dialogs/FeedbackDialog.ts
+++ b/packages/customer-satisfaction.gbapp/dialogs/FeedbackDialog.ts
@@ -79,7 +79,7 @@ export class FeedbackDialog extends IGBDialog {
         async step => {
           const locale = step.context.activity.locale;
           const rate = step.result.entity;
-          const user = await min.userProfile.get(context, {});
+          const user = await min.userProfile.get(step.context, {});
           await service.updateConversationRate(user.conversation, rate);
           await step.context.sendActivity(Messages[locale].thanks);
 
diff --git a/packages/customer-satisfaction.gbapp/dialogs/QualityDialog.ts b/packages/customer-satisfaction.gbapp/dialogs/QualityDialog.ts
index 696395a5c..e02275ea8 100644
--- a/packages/customer-satisfaction.gbapp/dialogs/QualityDialog.ts
+++ b/packages/customer-satisfaction.gbapp/dialogs/QualityDialog.ts
@@ -60,7 +60,7 @@ export class QualityDialog extends IGBDialog {
     min.dialogs.add(new WaterfallDialog('/quality', [
       async step =>  {
         const locale = step.context.activity.locale;
-        const user = await min.userProfile.get(context, {});
+        const user = await min.userProfile.get(step.context, {});
 
         const score = step.result;