fix: add missing Drivelution files to GeneralUpdate.Core compilation#300
Merged
Conversation
…csproj compilation list GeneralUpdate.Core links Drivelution source files individually. The 9-PR refactoring added 12 new files that were not included in the compile list, causing CS0234/CS0246 errors for Core.Execution, Core.Pipeline, UpdateProgress, BatchUpdateResult, etc. Added: - 6 Core/Pipeline/* files - 3 Core/Execution/* files - 1 Core/ServiceCollectionExtensions.cs - 2 Abstractions/Models/* (UpdateProgress, BatchUpdateResult) - Microsoft.Extensions.DependencyInjection.Abstractions for net10.0 target Full solution builds: 0 warnings, 0 errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneralUpdate.Core uses individual Compile Include links to Drivelution source files. The 9-PR refactoring added 12 new files that were not included.
Root cause
The refactoring created these new files under Drivelution but the Core project csproj explicitly lists each linked file — new files don't appear automatically.
Fix
Added 12 missing files to the net10.0 condition block + Microsoft.Extensions.DependencyInjection.Abstractions package reference.
Verification
Full solution build (GeneralUpdate.slnx): 0 warnings, 0 errors