Skip to content

Work around a probable grdview bug where it screws when shading and grid is nor 2-padded.#1995

Merged
joa-quim merged 2 commits into
masterfrom
fix-grdview-TRB
May 5, 2026
Merged

Work around a probable grdview bug where it screws when shading and grid is nor 2-padded.#1995
joa-quim merged 2 commits into
masterfrom
fix-grdview-TRB

Conversation

@joa-quim
Copy link
Copy Markdown
Member

@joa-quim joa-quim commented May 5, 2026

Let gd2gmt accept a gridreg option.

joa-quim added 2 commits May 5, 2026 17:54
…a non 2-padded grid.

Let gd2gmt accept a gridreg option.
…rid is nor 2-padded.

Let gd2gmt accept a gridreg option.
@joa-quim joa-quim merged commit 077cf02 into master May 5, 2026
2 of 7 checks passed
@joa-quim joa-quim deleted the fix-grdview-TRB branch May 5, 2026 17:04
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.87%. Comparing base (ff7c3f2) to head (eb7369e).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/gmt_main.jl 81.25% 3 Missing ⚠️
src/grdview.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1995      +/-   ##
==========================================
- Coverage   85.09%   84.87%   -0.23%     
==========================================
  Files         191      191              
  Lines       29048    29060      +12     
==========================================
- Hits        24719    24665      -54     
- Misses       4329     4395      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants