Add polar resampling via -Ar|t in plot, plot3d, and clip #5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #5260 for background. This PR implements the feature request in modules plot, plot3d, and clip. As an example of what this looks like I added a new test (polarcurves.sh) which produces this plot with -Ar|t vs no -A.
PaulWessel
added
the
new feature
PaulWessel
changed the title
Member
Author
|
Did you get a chance to check this out @seisman ? |
PaulWessel
added a commit
that referenced
this pull request
Jun 6, 2021
* WIP Let grdclip handle polar resampling via -Ar|t Inspired by #5260, do the same when creating mask grids from polygons if we wish to resample the input polygon along straight theta and r path segments. Merge after 6.2.0, and will have no effect until #5263 have been merged as well. * Update grdmask.c
maxrjones
added
new core module feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #5260 for background. This PR implements the feature request in modules plot, plot3d, and clip. As an example of what this looks like I added a new test (polarcurves.sh) which produces this plot with -Ar|t vs no -A:
I set the theta resampling interval to 1 degree for now - this may need to be revisited. To be merged after 6.2.0 release.