Let -f<col>s explicity set start of input trailing text #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least as long as GMT modules maintain record-by-record reading (i.e., as UNIX filters), we may not be able to reliable identify the start of trialing text if the first record has numbers in that column. If that happens, then any trailing text in subsequent columns will be read as NaN and basically lost. Using -f to explicitly state where trailing text starts makes the determination robust. Closes #5368.
PaulWessel
added
bug
joa-quim
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least as long as GMT modules maintain record-by-record reading (i.e., as UNIX filters), we may not always be able to reliable identify the start of trialing text if the first record has numbers in that column. If that happens, then any trailing text in subsequent columns will be read as NaN and basically lost. Using *-f*colt to explicitly state where trailing text starts makes the determination robust. Closes #5368.