Consolidate -A into -F for a more unified option#5613
Merged
Conversation
While -F let you choose among video options and add some suitable modifiers, animated GIF was not one of them and it had its own option -A with modifier. Yet, -A+s required -F to have been set, etc. This PR lets -F specify which products to build from the list of gif,png,mp4,webm and offers modifiers. The option is repeatable. We thus deprecate -A which will be handled via standard backwards compatibility rules.
Esteban82
approved these changes
Aug 9, 2021
Member
|
Should the scripts of the animations (1 to 5) be updated? |
Member
Author
|
Yes, they should (of course they are working via backwards compatibility). If you have time, please make a PR with the changes. |
Member
|
I am trying to update the scripts of the animations. Where I can find anim01.txt?? Is this the file of the script, right? .. literalinclude:: /_verbatim/anim01.txt |
Member
Author
|
anim01.txt and others like it are created on the fly by cmake so you only need to worry about the *.sh files. |
Esteban82
added a commit
that referenced
this pull request
Aug 13, 2021
Update based on modification of #5613. Let me know if it ok so I correct the other animations.
Merged
Esteban82
added a commit
that referenced
this pull request
Aug 13, 2021
* Update anim01.sh Update based on modification of #5613. Let me know if it ok so I correct the other animations. * Update anim02.sh * Update anim03.sh * Update anim04.sh * Update anim05.sh * Update anim09.sh This script only make a master frame, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While -F let you choose among video options and add some suitable modifiers, animated GIF was not one of them and it had its own option -A with modifier. Yet, -A+s required -F to have been set, etc. Same with -M, requiring -Fnone if no animation desired. This PR lets -F specify which products to build from the list of gif,png,mp4,webm and offers modifiers. The option is repeatable. We thus deprecate -A (now -Fgif) and -Fnone (now default) which will be handled via standard backwards compatibility rules. Closes #5522.