Clean up aspects of SVD function usage in GMT #5725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the gpsgridder cumulative and incremental grid output based on greenspline. Add +n for dry-runs (no grids, just eigenvalues) instead of relying on a negative argument.
PaulWessel
added
documentation
maxrjones
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate SVD operations and constants via a new set of constants in gmt_constants.h. These are just used in greenspline and gpsgridder for now.
Also update the gpsgridder cumulative and incremental grid output based on greenspline -C. Add +n for dry-runs (no grids, just eigenvalues) instead of relying on a negative argument. Simplified file name via -G in gpsgridder following the lead in greenspline. These changes are backward compatible. Finalized the -C+c+i stuff in gpsgridder based on how it works in greenspline. Have a new movie example that tests this and works. Minor speed-ups by checking for zero eigen-values in the loops.