Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let project -G accept increment unit and +n modifier #5984

Merged
merged 5 commits into from Nov 12, 2021
Merged

Conversation

PaulWessel
Copy link
Member

Description of proposed changes

The distance increment set in project has long been required to be in km, whereas most places in GMT we can specify what unit we want (e.g., 30n for 30 nautical miles or 2d for 2 spherical degrees) but not so in project. We were also unable to specify the number of points, which is pretty handy when you give a start and stop point and want to generate intermediate points. Thus, this PR:

  1. Adds the capability of providing the increment with the desired unit appended
  2. Adds modifier +n to indicate that the increment is number of points instead (which requires either -C and -E or -Z).
  3. Removes +n from -Z but in a backwards compatible way.

All tests pass except an undetected error in ellipses.sh where -Q was not passed so -G10 was interpreted (as it should be) as degrees. The script was updated to use -Q.

@PaulWessel PaulWessel added the enhancement Improving an existing feature label Nov 12, 2021
@PaulWessel PaulWessel added this to the 6.3.0 milestone Nov 12, 2021
@PaulWessel PaulWessel self-assigned this Nov 12, 2021
@Esteban82 Esteban82 merged commit d638d73 into master Nov 12, 2021
@Esteban82 Esteban82 deleted the project-units branch November 12, 2021 03:45
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants