Let shrink length for geovector be accepted in any valid map unit #6155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The +nnorm modifier for geovector was hardwired to be understood as km. This is not that useful when you want to specify a length of 1 spherical degree, having to do head-math to get 111.195079734 or similar. This PR does three things 1. Allows valid map units (arc units like d,m,s and e,k,n,M etc) 2. Checks if a confused user specifies the length in plot units and gives an error 3. Updates the usage syntax listed in plot and plot3 4. Updates the documentation to discuss the units.
PaulWessel
added
documentation
joa-quim
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The +nnorm modifier for geovectors was hardwired to be understood as km, while for Cartesian vectors the norm could be given with any plot unit (c|i|p). This limitation is not helpful when you want to specify a length of 1 spherical degree, having to do head-math to get 111.195079734 or similar. This PR does four things:
No tests affected. I may add a new test via another PR when as I am examining a possible issue related to shrinking heads.