Skip to content

Address items 3, 4, 7 in vector proposal #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2022
Merged

Address items 3, 4, 7 in vector proposal #6194

merged 2 commits into from
Jan 5, 2022

Conversation

@PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Jan 5, 2022

This PR addresses these three items in #6190:

(3) Allow +z in plot and plot3 to accept components for a geovector and have them scaled to map distances. Properly compute what azimuth and length this corresponds to and plot the geovector accordingly.
(4) Disable (or give error) +z in grdvector since here we control polar vs component via -A.
(7) Accept a default scale of 1 if +z has no argument (currently this would give junk).

No tests are affected.

Some examples of geovector components calls:

echo 0 60 100 100 | gmt plot -R-2/3/59/62 -JM10c -B -S=12p+e+z -W1p -Gred -pdf map
echo 0 60 100k 100M | gmt plot -R-2/3/59/62 -JM10c -B -S=12p+e+z -W1p -Gred -pdf map
echo 0 60 1 2 | gmt plot -R-2/3/59/62 -JM10c -B -S=12p+e+z100k -W1p -Gred -pdf map

@PaulWessel
Address items 3, 4, 7 in vector proposal
04308ee 
This PR addresses those items in #6190.  No tests are affected.
@PaulWessel
set types for both components
aebe8e6
@PaulWessel PaulWessel added the enhancement Improving an existing feature label Jan 5, 2022
@PaulWessel PaulWessel added this to the 6.4.0 milestone Jan 5, 2022
@PaulWessel PaulWessel self-assigned this Jan 5, 2022
@Esteban82
Copy link
Member

Esteban82 commented Jan 5, 2022

Are these ok?

map1
map2
map3

Esteban82
Esteban82 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@Esteban82 Esteban82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve because my tests looks fine.

@PaulWessel
Copy link
Member Author

PaulWessel commented Jan 5, 2022

I think so: 100 km is a bit shorter than 2 degrees longitude at 60 N

@PaulWessel PaulWessel merged commit e776117 into master Jan 5, 2022
@PaulWessel PaulWessel deleted the vector_improv1 branch January 5, 2022 03:49
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Esteban82 Esteban82 Esteban82 approved these changes

@joa-quim joa-quim Awaiting requested review from joa-quim

@maxrjones maxrjones Awaiting requested review from maxrjones

Assignees

@PaulWessel PaulWessel

Labels

add-changelog Add PR to the changelog enhancement Improving an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PaulWessel @Esteban82 @maxrjones