Let grdedit -D+c allow setting/removing default CPT for grid #6223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the cpt is now one of the attributes, we need a way to add, remove, or change it via grdedit. This PR adds +c[-|cpt] to the -D option. If no argument is used then we add the default CPT (turbo), if argument is - we remove any default CPT from the grid, else we add the specified CPT. The PR also fixed a bug that failed to consider NaNs as the NaN values and thus lead to uncessisary reading.
PaulWessel
added
enhancement
maxrjones
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the cpt is now one of the attributes, we need a way to add, remove, or change it via grdedit. This PR adds +c[-|cpt] to the -D option. If no argument is used then we add the default CPT (turbo), if argument is - we remove any default CPT from the grid, else we add the specified CPT. The PR also fixed a bug that failed to consider NaNs as the NaN values and thus lead to unnecessary reading.