Skip to content

Conversation

@PaulWessel
Copy link
Member

Description of proposed changes

As discussed in #6288, I unfortunately selected -M as the option for adding interior margins for a map inset, even though -C as used in subplot is the most comparable situation. This PR rectifies this by switching inset to use -C but of course retaining backwards compatibility with any -M use. Some related points:

  1. I ran all tests as they were first to ensure the -M options were correctly processed
  2. I then switched the 4 scripts that used -M to -C and ran the tests again
  3. Since the new -C has to also handle the syntax of -M it can now handle the old -C syntax plus -Cxmargin/ymargin and -Cwmargin/emargin/smargin/nmargin which is even more flexible than either previous option.
  4. It also turned out that inset had been left out of the synopsis reformatting (to use terminal width) so I fixed that in the process.

All tests still pass as before, the documentation has been updated. Once this PR is approved and merged I will enhance the -C option in subplot to be equally flexible.

@PaulWessel PaulWessel added documentation Improve documentation enhancement Improving an existing feature deprecation Deprecating a feature labels Feb 4, 2022
@PaulWessel PaulWessel added this to the 6.4.0 milestone Feb 4, 2022
@PaulWessel PaulWessel self-assigned this Feb 4, 2022
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maxrjones maxrjones added the add-changelog Add PR to the changelog label Feb 4, 2022
@PaulWessel PaulWessel merged commit 5ad0d04 into master Feb 4, 2022
@PaulWessel PaulWessel deleted the inset-update branch February 4, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-changelog Add PR to the changelog deprecation Deprecating a feature documentation Improve documentation enhancement Improving an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants