Skip to content

Let one-liners with CPTs add colorbar#6427

Merged
PaulWessel merged 2 commits intomasterfrom
one-liner-improvement
Mar 10, 2022
Merged

Let one-liners with CPTs add colorbar#6427
PaulWessel merged 2 commits intomasterfrom
one-liner-improvement

Conversation

@PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Mar 10, 2022

Without the colorbar, a colored image has little meaning if we cannot tell what values they represent.
This PR checks if the plotting module involves a CPT, and if so we place it on top via a colorbar -DJTC -Baf call.

Example: gmt grdimage @earth_relief_02m -RFR -B -png map

map

Closes #6426.

@PaulWessel
Let one-liners with CPTs add colorbar
ecb50a1 
Without the colorbar, a colored image has little meaning if we cannot tell what values they represent.
@PaulWessel PaulWessel added the enhancement Improving an existing feature label Mar 10, 2022
@PaulWessel PaulWessel added this to the 6.4.0 milestone Mar 10, 2022
@PaulWessel PaulWessel self-assigned this Mar 10, 2022
@PaulWessel PaulWessel merged commit 27bddce into master Mar 10, 2022
@PaulWessel PaulWessel deleted the one-liner-improvement branch March 10, 2022 12:06
@Esteban82
Copy link
Member

Esteban82 commented Mar 18, 2022

Just a question @PaulWessel.

Why do you decided to put the colorbar on top of the figure (-DJTC -Baf)?

In #6426 you suggest to use gmt colorbar -DJBC -B which is the default position for gmt colorbar.

@PaulWessel
Copy link
Member Author

PaulWessel commented Mar 18, 2022

I think because the default -B is -BWsne, but I am open to discussion.

@Esteban82
Copy link
Member

Esteban82 commented Mar 18, 2022

Ok. The issue is that if I run something like this I get a colorbar below. So, I think we should use the same default position of gmt colorbar.

gmt begin ...
	gmt grdimage $grd ...
	gmt colorbar 
gmt end

@maxrjones maxrjones added the add-changelog Add PR to the changelog label Mar 18, 2022
@maxrjones maxrjones mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joa-quim joa-quim joa-quim approved these changes

@seisman seisman Awaiting requested review from seisman

@maxrjones maxrjones Awaiting requested review from maxrjones

@Esteban82 Esteban82 Awaiting requested review from Esteban82

Assignees

@PaulWessel PaulWessel

Labels

add-changelog Add PR to the changelog enhancement Improving an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Let one-liners involving a CPT display colorbar

4 participants

@PaulWessel @Esteban82 @joa-quim @maxrjones