Allow contour files to only list contour level#6522
Merged
PaulWessel merged 1 commit intomasterfrom Apr 5, 2022
Merged
Conversation
Since it is awkward to create a list of desired contours and add the character C to the end, this PR allows a plain single-column file of contour levels to be accepted in -C by grdcontour and pscontour and the type defaults to plain contour (C) only. Currently we just get an ugly read error.
Contributor
|
Very nice. Reminds me of #559! |
joa-quim
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it is awkward to create a list of desired contours and add the character C to the end, this PR allows a plain single-column file of contour levels to be accepted in -C by grdcontour and pscontour and the type defaults to plain contour (C) only. Currently we just get an ugly read error. This is useful if you have some custom contours, e.g., want to contour close to zero but not exactly, then every 1:
This avoids having to awk to add C or to suffer a crash,