Skip to content

Conversation

@PaulWessel
Copy link
Member

This PR addresses a few bugs and improves documentation:

  1. Let grdflexure handle the combination of -H -W: If the load has variable load density then we must use the density at each node to compute the equivalent height for an average load density. Also, this must be done before we determine if any part of the load (now) sticks above sea level for the additional boost due to the greater density contrast with air.
  2. The check for NaNs in the input grid gave an error right away, hence we never even got to the section where the NaNs were replaced by zeros. Now fixed.
  3. Since this module as well as many others (gravfft, grdgravmag, grdvector) need to check if the two grids are truly co-registered I have added a new function gmt_grd_domains_match which consolidates the (many) checks into one function. These modules now use this function to simplify those checks.
  4. The effects of -H and -W on the load heights were never discussed - now the documentation explains what is going on.

No changes to any tests.

If the load has variable load density then we must use the density at each node to compute adjusted height before we determine if we now stick above sea level for the additional boost.
Also, the check for NaNs in the input grid gave an error hence we never even got to the section where the NaNs were replaced by zeros.  Now fixed.
@PaulWessel PaulWessel added bug Something isn't working documentation Improve documentation enhancement Improving an existing feature labels Jun 20, 2022
@PaulWessel PaulWessel added this to the 6.5.0 milestone Jun 20, 2022
@PaulWessel PaulWessel requested a review from joa-quim June 20, 2022 14:48
@PaulWessel PaulWessel self-assigned this Jun 20, 2022
@PaulWessel PaulWessel merged commit 85dff41 into master Jun 20, 2022
@PaulWessel PaulWessel deleted the load-NaN-boost branch June 20, 2022 15:26
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-changelog Add PR to the changelog bug Something isn't working documentation Improve documentation enhancement Improving an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants