Fix mistake in using +1|2 instead of +d1|2 in grdinterpolate -F #6958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason (lack of coffee, premature insanity) I implemented grdinterpolate using the deprecated +1|2 for first or second derivative of the spline specified in -F. However, sample1d has -F and it was upgraded to +d some time ago. Perhaps I forgot to upgrade grdinterpolate. Amyway, this PR updates the syntax and parsing and will quietly honor the deprecated +1|2 modifier.
PaulWessel
added
documentation
rbdavis
approved these changes
Aug 15, 2022
Member
Author
|
@rbdavis you may wish to merge master into your branch related to grdinterpolate now so that you can handle any conflicts up front. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason (lack of coffee, premature insanity, etc.) I implemented grdinterpolate using the deprecated +1|2 for first or second derivative of the spline specified in -F. However, sample1d also has -F and it was upgraded to +d some time ago. Perhaps I forgot to upgrade grdinterpolate. Anyway, this PR updates the syntax and parsing and will quietly honor the deprecated +1|2 modifier.