Conversation
While we have allowed the user to specify the width and set height to 0 and use the image aspect ratio to compute the height, we did not allow the reverse: Specify width as zero and compute it from height and aspect ratio. This PR implements this capability and updates the docs.
Esteban82
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we have allowed the user to specify the width and set height to 0 and use the image aspect ratio to compute the height, we did not allow the reverse: Specify width as zero and compute it from height and aspect ratio. This PR implements this capability and updates the docs.