Let movie -A handle addition of audio track #7461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thie enhancement allows users to add a narration (or any sound) track to their animation. Via +e the length of teh audio can be stratched to exactly fit the anomation length.
PaulWessel
added
documentation
Member
|
Ok, great @PaulWessel. I will test it. Probably tonight or tomorrow. Will we need to make a test for gmt/test/movie also? |
Member
Author
|
Hard to test movies. Maybe eventually we only create master frame pdf and compare with original |
Also add a few check for -A, e.g., file must exist.
Contributor
|
I tried adding an mp3-file to an mp4 movie. This resulted in the movie containing only the audio, and not any video. Maybe @Esteban82 will be luckier. (Sorry - couldn't wait testing) |
Member
Author
|
I just updated movie.c and also the Indiana Jones track with audio and it worked brilliantly. |
Member
|
I inverse the ratio formula. I test it with the Indiana Jones script. When I reduce length of movie ( |
Esteban82
approved these changes
May 16, 2023
Member
Author
|
Thanks, good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thie enhancement allows users to add a narration (or any sound) track to their animation. Via +e the length of the audio can be stretched to exactly fit the animation length.
@Esteban82, this PR compiles but I have not tested any of it. If you have time then please do. The key coding is in movie.c starting around line 2620.