Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings and improve colorbar gallery example #596

Merged
merged 5 commits into from Sep 27, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Sep 10, 2020

Description of proposed changes

Prevents the "Axis sub-item a/f set more than once (typo?)" warning from showing up, and also make the colorbar gallery example a bit nicer than the original one made in #332.

Live preview is at https://pygmt-git-improve-gallery-colorbar.gmt.vercel.app/gallery/plot/colorbar.html. See also teaser image below (which should dynamically update if the code in this PR changes).

New colorbar gallery example

Fixes #595

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 added the documentation Improvements or additions to documentation label Sep 10, 2020
@weiji14 weiji14 added this to the 0.2.1 milestone Sep 20, 2020
@weiji14 weiji14 changed the title Improve and remove warnings from gallery colorbar example Remove warnings and improve colorbar gallery example Sep 27, 2020
@weiji14 weiji14 marked this pull request as ready for review September 27, 2020 03:46
examples/gallery/plot/colorbar.py Outdated Show resolved Hide resolved
examples/gallery/plot/colorbar.py Outdated Show resolved Hide resolved
examples/gallery/plot/colorbar.py Outdated Show resolved Hide resolved
examples/gallery/plot/colorbar.py Outdated Show resolved Hide resolved
examples/gallery/plot/colorbar.py Outdated Show resolved Hide resolved
Co-Authored-By: Dongdong Tian <seisman.info@gmail.com>
@weiji14 weiji14 merged commit 7bedf48 into master Sep 27, 2020
@weiji14 weiji14 deleted the improve-gallery-colorbar branch September 27, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the colorbar example
2 participants