Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: numpad ENTER key doesn't work #117

Closed
AndroidDeveloperLB opened this issue Apr 8, 2018 · 6 comments

Comments

@AndroidDeveloperLB
Copy link

commented Apr 8, 2018

Only the normal one in the middle of the keyboard works.
The one on the far right side doesn't do anything.

@rom1v rom1v self-assigned this Apr 8, 2018

rom1v added a commit that referenced this issue Apr 8, 2018
Map numpad ENTER key
Forward numpad ENTER key to the device.

Fixes <#117>.
@rom1v

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2018

Thank you for the report 👍

I just fixed it on master.

@rom1v rom1v closed this Apr 8, 2018

@AndroidDeveloperLB

This comment has been minimized.

Copy link
Author

commented Apr 8, 2018

@rom1v Thank you. I'm happy you understood what I meant.

@AndroidDeveloperLB

This comment has been minimized.

Copy link
Author

commented Jun 2, 2019

I can still see this issue. It acts as space this time instead of enter.
Why is it closed?
In order to test, open Chrome, and on Google's website (not on the address bar), search for something using the small Enter key.

Tested on v1.8 , with Galaxy S7 , Android 8.0.0

@rom1v

This comment has been minimized.

Copy link
Collaborator

commented Jun 2, 2019

I can still see this issue.

It's not the same issue.

It acts as space this time instead of enter.

Indeed, even in the Firefox address bar. But in a text field, it correctly acts as "enter" (try in google.com for example).

Technically, it is correctly bound to KEYCODE_NUMPAD_ENTER:

MAP(SDLK_KP_ENTER, AKEYCODE_NUMPAD_ENTER);

By the way, it is the same behavior with:

adb shell input keyevent KEYCODE_NUMPAD_ENTER

I don't know why Android considers KEYCODE_NUMPAD_ENTER as a space in some contexts…

@AndroidDeveloperLB

This comment has been minimized.

Copy link
Author

commented Jun 2, 2019

I see. The reason I thought it's because of this tool, is that the callback of setOnEditorActionListener doesn't get called when I press the small Enter key.
I think it's a bug on Android itself, then, because there shouldn't be a difference between pressing on the large one and the small one...
No?

@AndroidDeveloperLB

This comment has been minimized.

Copy link
Author

commented Jun 2, 2019

When running on emulator, it doesn't even put a space.
How odd. I've reported it here:
https://issuetracker.google.com/issues/134205188

So the small Enter key can't be handled officially...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.