Forward audio#3703
Closed
yume-chan wants to merge 8 commits into
Closed
Conversation
yume-chan
force-pushed
the
feat/forward-audio
branch
from
2d2ac6f to
ec3ccbf
Compare
For the initial connection between the device and the computer, an adb
tunnel is established (with "adb reverse" or "adb forward").
The device-side of the tunnel is a local socket having the hard-coded
name "scrcpy". This may cause issues when several scrcpy instances are
started in a few seconds for the same device, since they will try to
bind the same name.
To avoid conflicts, make the client generate a random UID, and append
this UID to the local socket name ("scrcpy_01234567").
yume-chan
force-pushed
the
feat/forward-audio
branch
from
ec3ccbf to
2a09b16
Compare
Contributor
Author
|
Replaced by #3757 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14
Android version support:
com.android.shellpackage doesn't haveRECORD_AUDIOpermission declared.FakePackageNameContexthack to "fix" Android permission check.FakePackageNameContexthack to "fix" Android permission check. No "Share heap dump" hack required.New option:
--no-forward-audioon client side,forward_audioon server side. Forwarding is enabled by default.Socket order:
video -> [control] -> [audio]
Control and audio sockets may be absent if
--no-controlor--no-forward-audiois specified, but the order is maintained.Audio compression:
No compression used, so the audio stream can be easily played at client side. The bandwidth is 48000Hz x 16bits x 2 channels = 1536000 bits =192000 bytes = 192KB = 187.5KiB per second, so I don't think it needs compression (at least on wired connection).
Latency:
The latency is around 30ms, tested in a rhythm game. And in one hour of continue using, the latency is seemingly increasing. Maybe it still requires packet header and time-stamping.