Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: editing is limited to 10 digits in a integer field #1819

Closed
lixun910 opened this issue Feb 20, 2019 · 9 comments
Closed

Table: editing is limited to 10 digits in a integer field #1819

lixun910 opened this issue Feb 20, 2019 · 9 comments
Assignees

Comments

@lixun910
Copy link
Member

No description provided.

@lixun910 lixun910 self-assigned this Feb 20, 2019
@lixun910
Copy link
Member Author

Step: (in Table) right click->Add Variable;
Add a new integer variable
Edit the cell in the newly created column, e.g. input 12345678901
It only allows to input up to 10 digits.

Fixed in V201

@Ashitacarl
Copy link

GeoDa 1.12.1.201 (macOS Mojave, 10.14.3). Feb. 20 build.

Fix verified. Integers now allow more than 10 digits (the new limit is 19 digits).

1819

@lixun910
Copy link
Member Author

Thanks, @Ashitacarl
Yes, the new limit is 19 digits, which is for max value of int64 number: 9223372036854775807

@lixun910
Copy link
Member Author

When input number in the newly created column (integer type), the number is NOT right-aligned.

@lixun910 lixun910 reopened this Feb 26, 2019
lixun910 added a commit to lixun910/geoda that referenced this issue Feb 26, 2019
…lumn (integer type)

add a customized wxGridCellInt64Renderer and  wxGridCellInt64Editor to support int64 integer column and format the content using right-aligned text
lixun910 added a commit to lixun910/geoda that referenced this issue Feb 26, 2019
lixun910 added a commit to lixun910/geoda that referenced this issue Feb 27, 2019
…erValidator that doesn't support on wx3.1.0 for osx 10.7
@lixun910
Copy link
Member Author

lixun910 commented Mar 5, 2019

continue:

  1. “displayed decimal places” in table can't be saved to GeoDa project (.gda) file.
  2. add "default displayed decimal places" option in preference dialog

@lixun910
Copy link
Member Author

lixun910 commented Mar 6, 2019

Users can set "default displayed decimal places" in the Preference dialog.

  1. Users need to reopen the dataset to apply the new setting.
  2. If using a GeoDa project file (*.gda), the displayed decimal places in *.gda file will overwrite the setting in the Preference dialog.

screen shot 2019-03-06 at 1 38 30 pm

@lixun910
Copy link
Member Author

lixun910 commented Mar 6, 2019

Fix in V205
When save a GeoDa .gda file, the displayed decimal places should be written in .gda file. GeoDa will read and use the displayed decimal places in .gda file.

screen shot 2019-03-06 at 1 48 56 pm

@lixun910
Copy link
Member Author

lixun910 commented Mar 8, 2019

The fix of this issue by introducing new types of cell editor also touches the logic of "Add ID Variable":

In this fix, when a new column is inserted into table, all cell values are set to undefined (or empty) flag. So that user will get a "empty" newly created column:
Screen Shot 2019-03-08 at 1 48 21 PM

However, using "Add ID variable" to insert a new column with values, the undefined flags should be set to "false" so that the program can read the values in this column. Otherwise, the POLY_ID column will be empty:
Screen Shot 2019-03-08 at 1 54 18 PM

This issue needs to be fixed.

@Ashitacarl
Copy link

Ashitacarl commented Mar 20, 2019

GeoDa 1.12.1.211 (macOS Mojave, 10.14.3). Mar. 18 build.

Fix verified.

  1. New option "Default displayed decimal places in Table" in Preferences/Data Source that applies to all tables imported to GeoDa. This only influences the displayed decimal places but not actual decimal places.

  2. GeoDa project file (*.Gda) can save the decimal places and overwrite that specified in default preferences.

1819-3

  1. Add ID variable does not produce an empty column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants