Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Local neighbor match test #2222

Closed
lixun910 opened this issue Oct 1, 2020 · 0 comments
Closed

bug: Local neighbor match test #2222

lixun910 opened this issue Oct 1, 2020 · 0 comments
Assignees

Comments

@lixun910
Copy link
Member

lixun910 commented Oct 1, 2020

In the local neighbor match test, the value for pval when there are no neighbor matches,
i.e., when cardinality = 0 is given as 0.0000. That is not correct. Strictly speaking, it should
be 1 - sum of pval for all cardinalities, but if that is not practical, we should set it to something
like 1.000 or missing.

@lixun910 lixun910 self-assigned this Oct 1, 2020
lixun910 added a commit to lixun910/geoda that referenced this issue Oct 1, 2020
set the p-value to empty when cardinality = 0
(it should be 1 - sum of pval for all cardinalities)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant