Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geonode's homepage does not count 'wmsStore' as a 'countable-geonode' layer #2412

Closed
dalda opened this issue Jan 29, 2016 · 7 comments
Closed

Comments

@dalda
Copy link

dalda commented Jan 29, 2016

Geonode's homepage counts consider 'coverageStore', 'dataStore', 'remoteStore' but it doesn't count 'wmsStore' (cascaded WMS for example). According to the developer's team it should,

@jj0hns0n
Copy link
Member

I also noticed this on another geonode recently.

@capooti
Copy link
Member

capooti commented Feb 3, 2016

If I remember correctly, all of the remote services (WMS/ESRI/whatever) are
registered as remoteStore.
What you want to get should be easily accomplished with some customization.

On Fri, Jan 29, 2016 at 7:03 AM, Jeffrey Johnson notifications@github.com
wrote:

I also noticed this on another geonode recently.


Reply to this email directly or view it on GitHub
#2412 (comment).

Paolo Corti
Geospatial software developer
web: http://www.paolocorti.net
twitter: @capooti
skype: capooti

@jj0hns0n
Copy link
Member

jj0hns0n commented Feb 4, 2016

I think the issue may be when you configure a remote WMS store yourself
through GeoServer and do updatelayers vs adding them as a remote service
layer through geonode. We should include wmsStore in the count I think.

On Thu, Feb 4, 2016 at 3:17 AM, Paolo Corti notifications@github.com
wrote:

If I remember correctly, all of the remote services (WMS/ESRI/whatever) are
registered as remoteStore.
What you want to get should be easily accomplished with some customization.

On Fri, Jan 29, 2016 at 7:03 AM, Jeffrey Johnson <notifications@github.com

wrote:

I also noticed this on another geonode recently.


Reply to this email directly or view it on GitHub
#2412 (comment).

Paolo Corti
Geospatial software developer
web: http://www.paolocorti.net
twitter: @capooti
skype: capooti


Reply to this email directly or view it on GitHub
#2412 (comment).

@dalda
Copy link
Author

dalda commented Feb 4, 2016

I've just added a pull request about this issue.

@capooti
Copy link
Member

capooti commented Feb 4, 2016

Ah ok, thanks Jeff
Dalda, could you squash your commits and resend the PR?
thanks
p

On Thu, Feb 4, 2016 at 2:45 AM, dalda notifications@github.com wrote:

I've just added a pull request about this issue.


Reply to this email directly or view it on GitHub
#2412 (comment).

Paolo Corti
Geospatial software developer
web: http://www.paolocorti.net
twitter: @capooti
skype: capooti

@dalda
Copy link
Author

dalda commented Feb 5, 2016

Hi, sure! But I'm quite a newbie in Github and don't really know how to squash my commits...

@jj0hns0n
Copy link
Member

jj0hns0n commented Feb 5, 2016

I just went ahead and merged this ... but for future reference
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

On Fri, Feb 5, 2016 at 8:12 AM, dalda notifications@github.com wrote:

Hi, sure! But I'm quite a newbie in Github and don't really know how to
squash my commits...


Reply to this email directly or view it on GitHub
#2412 (comment).

@simod simod closed this as completed Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants