Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

GNIP 30 - Split out geonode.maps into 2 modules #273

Closed
sbenthall opened this Issue · 8 comments

5 participants

@sbenthall
Owner

http://github.com/GeoNode/geonode/wiki/GNIP-30----Split-out-geonode.maps-into-2-modules

It is proposed to split the geonode.maps module into 2 separate modules: geonode.data (or geonode.layers) to handle all interactions with data itself, and geonode.maps to handle the maps. This reorganization would be used to reorganize each of the new constituent files (models.py, views.py etc) more logically (similar or related methods together) and to add docstrings for all methods in the process.

This change would require a database migration that django-south can't handle and so could involve some pain. On the other hand, it's intended to make things easier on developers.

@jj0hns0n jj0hns0n was assigned
@sbenthall
Owner

Since this is a change intended to make things easier for developers, I think that other developers need to weigh in on it for it to be approved.

@simod
Owner

I'm +1 on this (by naming layers instead of data). Thanks!

@tomkralidis
Owner

+1

@jj0hns0n
Owner
@rmarianski

+1.

Just out of curiosity, will we be able to provide a migration story outside of south?

@jj0hns0n
Owner
@rmarianski

Good idea. Due to the amount of reorganization that is going on, a backup/restore might be a nice way to tackle all the different model changes at once.

@jj0hns0n
Owner

Can we just close this since its done. Not sure about migrations, but the actual migration is done.

@jj0hns0n jj0hns0n closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.