Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Services] Mitigate name clashes for service names #3914

Closed
afabiani opened this issue Sep 13, 2018 · 0 comments
Closed

[Remote Services] Mitigate name clashes for service names #3914

afabiani opened this issue Sep 13, 2018 · 0 comments
Assignees
Labels
major A high priority issue which might affect a lot of people or large parts of the codebase

Comments

@afabiani
Copy link
Member

afabiani commented Sep 13, 2018

Currently the name of a service, which is supposed to be unique, is built with a slugify/hashing mechanism which does not guarantee quite well that there won't clashes and conflicts when registering different services.

Improve it so that the possibility of clashes is mitigated.

WMS service names have to be unique, however they are determined from the netloc part of the service URL only and are restricted to 40 characters (the field definition in services.models.Service allows for 255 characters).

This can lead to name clashes if e.g. multiple services are available on the same network location. Examples:

http://www.lfu.bayern.de/gdi/wms/wasser/abwasser?request=GetCapabilities&service=WMS
http://www.lfu.bayern.de/gdi/wms/wasser/wsg?service=wms&request=GetCapabilities

are different WMS services using the same network location.

Suggestion:

Use the entire service URL for name determination and use all available 255 characters to avoid name clashes.

@afabiani afabiani added the major A high priority issue which might affect a lot of people or large parts of the codebase label Sep 13, 2018
@afabiani afabiani self-assigned this Sep 13, 2018
afabiani pushed a commit that referenced this issue Sep 17, 2018
[Fixes #3914] [Remote Services] Mitigate name clashes for service names
afabiani pushed a commit that referenced this issue Sep 18, 2018
[Backport 2.7.x] [Fixes #3914] [Remote Services] Mitigate name clashes for service names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major A high priority issue which might affect a lot of people or large parts of the codebase
Projects
None yet
Development

No branches or pull requests

1 participant