Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Map Composer Query box behavior wonky #543

Open
matthewhanson opened this Issue Nov 16, 2012 · 7 comments

Comments

Projects
None yet
7 participants
Member

matthewhanson commented Nov 16, 2012

In Map Composer:

Load vector layer, hit Query button. The Query window, and the Query results window both pop up.

There are two issues that are very similar.

  1. If you press Cancel in the Query window it says "Querying", but then does nothing. I'd think that Cancel should close the window

  2. There's no way to close the Query results window once opened. Pressing the Query button up top will close the Query window, but not the Query Results window.

Contributor

bartvde commented Nov 19, 2012

@matthewhanson is this based on #538 ?

Owner

jj0hns0n commented Nov 19, 2012

@bartvde, yep, he (and others) have been testing against
ui.dev.geonode.orgthat has that pulled.

On Mon, Nov 19, 2012 at 12:44 AM, Bart van den Eijnden <
notifications@github.com> wrote:

@matthewhanson https://github.com/matthewhanson is this based on #538#538?


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/issues/543#issuecomment-10505019.

Owner

capooti commented Apr 15, 2014

  1. We could change the text button to "Clear" rather than "Cancel".
  2. There is a small arrow button in order to close

@ingenieroariel ingenieroariel modified the milestone: 2.1 Apr 16, 2014

Contributor

al3mon commented Nov 26, 2014

The same as #1788

@jj0hns0n jj0hns0n removed the needs-triage label Jan 13, 2015

Owner

jj0hns0n commented Feb 4, 2015

@bartvde sorry to keep bugging you about things. How hard is it for us to change the "Cancel" button to "Clear"

image

And to have the query button close the entire panel (Query and Table panels) vs just the Query one?

We have our own fork of both gxp and suite but not sure where to make these kinds of changes. If you can point us in the right direction, we may be able to fix it ourselves.

Contributor

bartvde commented Feb 4, 2015

For the text you can change it here: https://github.com/boundlessgeo/gxp/blob/master/src/script/plugins/QueryForm.js#L64

or just set gxp.plugins.QueryForm.prototype.cancelButtonText = 'Clear'; at the GeoNode level.

The other question I need to investigate a bit more.

Contributor

bartvde commented Feb 4, 2015

As for the second question, you can modify the code here:

https://github.com/boundlessgeo/gxp/blob/master/src/script/plugins/QueryForm.js#L145

and add this line:

Ext.getCmp('table').ownerCt[pressed ? 'expand' : 'collapse']();

@simod simod removed the bug label Nov 17, 2015

@jj0hns0n jj0hns0n modified the milestones: 2.4, 2.5.x Nov 18, 2015

@jj0hns0n jj0hns0n modified the milestones: Low Priority, 2.5 Aug 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment