Display and save GeoRSS feeds as map layers #539

Closed
wants to merge 23 commits into
from

Conversation

Projects
None yet
5 participants
@mbertrand
Member

mbertrand commented Nov 16, 2012

Pull request for GNIP 23 - Add GeoRSS Layers such as Picasa and Youtube Feeds

This functionality depends on another pull request for gxp - opengeo/gxp#161 - where most of the changes were made.

@jj0hns0n

This comment has been minimized.

Show comment
Hide comment
@jj0hns0n

jj0hns0n Nov 16, 2012

Member

Guessing that @bartvde will need to help us adapt this to work with the
geoexplorer branch. This is a good use case for how to deal with things
that need to change in GXP when we are using mainline geoexplorer.
@ahocevar your thoughts would also be good.

On Fri, Nov 16, 2012 at 10:26 AM, Matt Bertrand notifications@github.comwrote:

Pull request for GNIP 23 - Add GeoRSS Layers such as Picasa and Youtube
Feedshttps://github.com/GeoNode/geonode/wiki/GNIP-23---Add-GeoRSS-Layers-such-as-Picasa-and-Youtube-Feeds

This functionality depends on another pull request for gxp -
opengeo/gxp#161 opengeo/gxp#161 - where most

of the changes were made.

You can merge this Pull Request by running:

git pull https://github.com/cga-harvard/cga-worldmap devfeeds

Or view, comment on, or merge it at:

#539
Commit Summary

  • initial port of feed layers/sources
  • Support for GeoRSS feed layers
  • gxp
  • Remove feed code from here because it may soon disappear
  • Add legend override for vector layers to geo_header.html; add
    javascr…
  • Reset gxp submodule

File Changes

  • M geonode-client/buildjs.cfg (11)
  • M geonode/layers/templates/layers/layer_geoext_map.html (9)
  • M geonode/maps/templates/maps/map_embed.html (7)
  • M geonode/maps/templates/maps/map_include.html (7)
  • M geonode/maps/templates/maps/map_view.html (96)
  • M geonode/templates/geonode/geo_header.html (23)

Patch Links

Member

jj0hns0n commented Nov 16, 2012

Guessing that @bartvde will need to help us adapt this to work with the
geoexplorer branch. This is a good use case for how to deal with things
that need to change in GXP when we are using mainline geoexplorer.
@ahocevar your thoughts would also be good.

On Fri, Nov 16, 2012 at 10:26 AM, Matt Bertrand notifications@github.comwrote:

Pull request for GNIP 23 - Add GeoRSS Layers such as Picasa and Youtube
Feedshttps://github.com/GeoNode/geonode/wiki/GNIP-23---Add-GeoRSS-Layers-such-as-Picasa-and-Youtube-Feeds

This functionality depends on another pull request for gxp -
opengeo/gxp#161 opengeo/gxp#161 - where most

of the changes were made.

You can merge this Pull Request by running:

git pull https://github.com/cga-harvard/cga-worldmap devfeeds

Or view, comment on, or merge it at:

#539
Commit Summary

  • initial port of feed layers/sources
  • Support for GeoRSS feed layers
  • gxp
  • Remove feed code from here because it may soon disappear
  • Add legend override for vector layers to geo_header.html; add
    javascr…
  • Reset gxp submodule

File Changes

  • M geonode-client/buildjs.cfg (11)
  • M geonode/layers/templates/layers/layer_geoext_map.html (9)
  • M geonode/maps/templates/maps/map_embed.html (7)
  • M geonode/maps/templates/maps/map_include.html (7)
  • M geonode/maps/templates/maps/map_view.html (96)
  • M geonode/templates/geonode/geo_header.html (23)

Patch Links

@ahocevar

This comment has been minimized.

Show comment
Hide comment
@ahocevar

ahocevar Nov 19, 2012

Member

In my opinion it is ok to accept contributions for gxp. We have done this before. So it is mostly a resourcing question to make sure there is time for reviews. Even better than doing reviews for large contributions when the code is already written would be to discuss them beforehand on the gxp list.

Member

ahocevar commented Nov 19, 2012

In my opinion it is ok to accept contributions for gxp. We have done this before. So it is mostly a resourcing question to make sure there is time for reviews. Even better than doing reviews for large contributions when the code is already written would be to discuss them beforehand on the gxp list.

@jj0hns0n

This comment has been minimized.

Show comment
Hide comment
@jj0hns0n

jj0hns0n Nov 26, 2012

Member

@ahocevar, lets discuss this while we are together in NoLa this week. I
think there are 2 issues here, 1) how to get this stuff into GXP properly,
and 2) how we make use of this in geonode now that we have switched to
using out of the box geoexplorere. @bartvde discussed setting up a service
where we could pass a build.cfg and get back a built GeoExplorer.js. That
makes sense to me, but not sure how to best go about it.

On Mon, Nov 19, 2012 at 6:18 AM, ahocevar notifications@github.com wrote:

In my opinion it is ok to accept contributions for gxp. We have done this
before. So it is mostly a resourcing question to make sure there is time
for reviews. Even better than doing reviews for large contributions when
the code is already written would be to discuss them beforehand on the gxp
list gxp@opengeo.org.


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-10514839.

Member

jj0hns0n commented Nov 26, 2012

@ahocevar, lets discuss this while we are together in NoLa this week. I
think there are 2 issues here, 1) how to get this stuff into GXP properly,
and 2) how we make use of this in geonode now that we have switched to
using out of the box geoexplorere. @bartvde discussed setting up a service
where we could pass a build.cfg and get back a built GeoExplorer.js. That
makes sense to me, but not sure how to best go about it.

On Mon, Nov 19, 2012 at 6:18 AM, ahocevar notifications@github.com wrote:

In my opinion it is ok to accept contributions for gxp. We have done this
before. So it is mostly a resourcing question to make sure there is time
for reviews. Even better than doing reviews for large contributions when
the code is already written would be to discuss them beforehand on the gxp
list gxp@opengeo.org.


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-10514839.

@jj0hns0n

This comment has been minimized.

Show comment
Hide comment
@jj0hns0n

jj0hns0n Dec 6, 2012

Member

@ahocevar and @bartvde what was the final story on this. Can we pull the stuff we need into GXP and reference it in our tree without having to do a custom geonode-client build in place?

Member

jj0hns0n commented Dec 6, 2012

@ahocevar and @bartvde what was the final story on this. Can we pull the stuff we need into GXP and reference it in our tree without having to do a custom geonode-client build in place?

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Dec 6, 2012

Contributor

Once the GXP PR gets merged, we will make sure all the dependencies are in GXP, just like we did for catalog search in add layers in the code sprint. @ahocevar was okay with this approach.

Contributor

bartvde commented Dec 6, 2012

Once the GXP PR gets merged, we will make sure all the dependencies are in GXP, just like we did for catalog search in add layers in the code sprint. @ahocevar was okay with this approach.

@ingenieroariel

This comment has been minimized.

Show comment
Hide comment
@ingenieroariel

ingenieroariel Jan 14, 2013

Member

The GXP PR is closed and @mbertrand added some commits. Is this ready to be merged?

opengeo/gxp#161

Member

ingenieroariel commented Jan 14, 2013

The GXP PR is closed and @mbertrand added some commits. Is this ready to be merged?

opengeo/gxp#161

@mbertrand

This comment has been minimized.

Show comment
Hide comment
@mbertrand

mbertrand Jan 14, 2013

Member

Looks like I will need to make additional changes to some files involved
in this pull-request to bring it up to date with the latest in dev.

On 01/14/2013 02:48 PM, Ariel Núñez wrote:

The GXP PR is closed and @mbertrand https://github.com/mbertrand
added some commits. Is this ready to be merged?

opengeo/gxp#161 opengeo/gxp#161


Reply to this email directly or view it on GitHub
#539 (comment).

Member

mbertrand commented Jan 14, 2013

Looks like I will need to make additional changes to some files involved
in this pull-request to bring it up to date with the latest in dev.

On 01/14/2013 02:48 PM, Ariel Núñez wrote:

The GXP PR is closed and @mbertrand https://github.com/mbertrand
added some commits. Is this ready to be merged?

opengeo/gxp#161 opengeo/gxp#161


Reply to this email directly or view it on GitHub
#539 (comment).

@jj0hns0n

This comment has been minimized.

Show comment
Hide comment
@jj0hns0n

jj0hns0n Jan 14, 2013

Member

Please consult @bartvde for help. He is our geoexplorer guru nowadays.
Thanks for keeping up on this.

On Mon, Jan 14, 2013 at 3:20 PM, Matt Bertrand notifications@github.comwrote:

Looks like I will need to make additional changes to some files involved
in this pull-request to bring it up to date with the latest in dev.

On 01/14/2013 02:48 PM, Ariel Núñez wrote:

The GXP PR is closed and @mbertrand https://github.com/mbertrand
added some commits. Is this ready to be merged?

opengeo/gxp#161 opengeo/gxp#161


Reply to this email directly or view it on GitHub
#539 (comment).


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-12245601.

Member

jj0hns0n commented Jan 14, 2013

Please consult @bartvde for help. He is our geoexplorer guru nowadays.
Thanks for keeping up on this.

On Mon, Jan 14, 2013 at 3:20 PM, Matt Bertrand notifications@github.comwrote:

Looks like I will need to make additional changes to some files involved
in this pull-request to bring it up to date with the latest in dev.

On 01/14/2013 02:48 PM, Ariel Núñez wrote:

The GXP PR is closed and @mbertrand https://github.com/mbertrand
added some commits. Is this ready to be merged?

opengeo/gxp#161 opengeo/gxp#161


Reply to this email directly or view it on GitHub
#539 (comment).


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-12245601.

@mbertrand

This comment has been minimized.

Show comment
Hide comment
@mbertrand

mbertrand Jan 16, 2013

Member

Hi @bartvde, what's the procedure now for adding additional gxp plugins/widgets that aren't included by default w/GeoExplorer?

Member

mbertrand commented Jan 16, 2013

Hi @bartvde, what's the procedure now for adding additional gxp plugins/widgets that aren't included by default w/GeoExplorer?

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Jan 16, 2013

Contributor

@mbertrand the procedure is to add the dependencies at the GXP/GeoExplorer level

Contributor

bartvde commented Jan 16, 2013

@mbertrand the procedure is to add the dependencies at the GXP/GeoExplorer level

@mbertrand

This comment has been minimized.

Show comment
Hide comment
@mbertrand

mbertrand Jan 16, 2013

Member

Thanks @bartvde, here's the situation with the feed tool:

GXP FeedSourceDialog widget requires the FeedSource plugin, but the
PicasaFeedSource and YouTubeFeedSource plugins are optional (it checks
to see if they are present) -
https://github.com/opengeo/gxp/blob/master/src/script/widgets/FeedSourceDialog.js#L81.

Do I need to make these plugins required rather than optional in GXP to
have them included in GeoExplorer? Or can I add them somewhere in the
packaged version of GeoExplorer supplied with GeoNode? If so, what is
the process for doing so?

-Matt

On 01/16/2013 10:10 AM, Bart van den Eijnden wrote:

@mbertrand https://github.com/mbertrand the procedure is to add the
dependencies at the GXP/GeoExplorer level


Reply to this email directly or view it on GitHub
#539 (comment).

Member

mbertrand commented Jan 16, 2013

Thanks @bartvde, here's the situation with the feed tool:

GXP FeedSourceDialog widget requires the FeedSource plugin, but the
PicasaFeedSource and YouTubeFeedSource plugins are optional (it checks
to see if they are present) -
https://github.com/opengeo/gxp/blob/master/src/script/widgets/FeedSourceDialog.js#L81.

Do I need to make these plugins required rather than optional in GXP to
have them included in GeoExplorer? Or can I add them somewhere in the
packaged version of GeoExplorer supplied with GeoNode? If so, what is
the process for doing so?

-Matt

On 01/16/2013 10:10 AM, Bart van den Eijnden wrote:

@mbertrand https://github.com/mbertrand the procedure is to add the
dependencies at the GXP/GeoExplorer level


Reply to this email directly or view it on GitHub
#539 (comment).

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Jan 17, 2013

Contributor

Yeah I would say just include them by default.

For GeoNode we don't have a good story right now since we got rid of the client, I think we would just use static script files there (and requirejs?)

Contributor

bartvde commented Jan 17, 2013

Yeah I would say just include them by default.

For GeoNode we don't have a good story right now since we got rid of the client, I think we would just use static script files there (and requirejs?)

@mbertrand

This comment has been minimized.

Show comment
Hide comment
@mbertrand

mbertrand Jan 17, 2013

Member

Submitted another PR to gxp making YouTube and Picasa feed sources required instead of optional.

Not sure if this is a bug or by design, but including additional tools in viewer config has no effect anymore, for example: https://github.com/cga-harvard/cga-worldmap/blob/95b4c19d1cc5bdffdaa5502b2484ba7774537343/geonode/maps/templates/maps/map_include.html#L9

Member

mbertrand commented Jan 17, 2013

Submitted another PR to gxp making YouTube and Picasa feed sources required instead of optional.

Not sure if this is a bug or by design, but including additional tools in viewer config has no effect anymore, for example: https://github.com/cga-harvard/cga-worldmap/blob/95b4c19d1cc5bdffdaa5502b2484ba7774537343/geonode/maps/templates/maps/map_include.html#L9

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Jan 18, 2013

Contributor

See the discussion here: opengeo/suite#51 so yes this is by design.

I originally had this change but it got reverted: bartvde/suite@8ce590e

Contributor

bartvde commented Jan 18, 2013

See the discussion here: opengeo/suite#51 so yes this is by design.

I originally had this change but it got reverted: bartvde/suite@8ce590e

@ingenieroariel

This comment has been minimized.

Show comment
Hide comment
@ingenieroariel

ingenieroariel Jan 22, 2013

Member

Adding a link to the PR in gxp for follow up:

opengeo/gxp#178

Member

ingenieroariel commented Jan 22, 2013

Adding a link to the PR in gxp for follow up:

opengeo/gxp#178

@ingenieroariel

This comment has been minimized.

Show comment
Hide comment
@ingenieroariel

ingenieroariel Feb 13, 2013

Member

The other pull request is already closed, @mbertrand please merge this one into master yourself ;)

Member

ingenieroariel commented Feb 13, 2013

The other pull request is already closed, @mbertrand please merge this one into master yourself ;)

@mbertrand

This comment has been minimized.

Show comment
Hide comment
@mbertrand

mbertrand Feb 14, 2013

Member

@ingenieroariel, @bartvde, I will merge as soon as the gxp changes get into GeoNode's bundled GeoExplorer.js - I don't think they're there yet?

Member

mbertrand commented Feb 14, 2013

@ingenieroariel, @bartvde, I will merge as soon as the gxp changes get into GeoNode's bundled GeoExplorer.js - I don't think they're there yet?

@ingenieroariel

This comment has been minimized.

Show comment
Hide comment
@ingenieroariel

ingenieroariel Feb 14, 2013

Member

@mbertrand I will release a new version of django-geoexplorer and upgrade
geonode to use it.

Member

ingenieroariel commented Feb 14, 2013

@mbertrand I will release a new version of django-geoexplorer and upgrade
geonode to use it.

@jj0hns0n

This comment has been minimized.

Show comment
Hide comment
@jj0hns0n

jj0hns0n Feb 19, 2013

Member

Ariel, any progress on this? Would like to see this included in Alpha5 if
possible.

On Thu, Feb 14, 2013 at 9:13 AM, Ariel Núñez notifications@github.comwrote:

@mbertrand I will release a new version of django-geoexplorer and upgrade
geonode to use it.


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-13566690.

Member

jj0hns0n commented Feb 19, 2013

Ariel, any progress on this? Would like to see this included in Alpha5 if
possible.

On Thu, Feb 14, 2013 at 9:13 AM, Ariel Núñez notifications@github.comwrote:

@mbertrand I will release a new version of django-geoexplorer and upgrade
geonode to use it.


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-13566690.

@ingenieroariel

This comment has been minimized.

Show comment
Hide comment
@ingenieroariel

ingenieroariel Feb 20, 2013

Member

The updated geoexplorer is now in our codebase

Member

ingenieroariel commented Feb 20, 2013

The updated geoexplorer is now in our codebase

@jj0hns0n

This comment has been minimized.

Show comment
Hide comment
@jj0hns0n

jj0hns0n Feb 20, 2013

Member

@mattbert @ingenieroariel can we go ahead and merge this now?

On Wed, Feb 20, 2013 at 7:26 AM, Ariel Núñez notifications@github.comwrote:

The updated geoexplorer is now in our codebase


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-13837268.

Member

jj0hns0n commented Feb 20, 2013

@mattbert @ingenieroariel can we go ahead and merge this now?

On Wed, Feb 20, 2013 at 7:26 AM, Ariel Núñez notifications@github.comwrote:

The updated geoexplorer is now in our codebase


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-13837268.

@ingenieroariel

This comment has been minimized.

Show comment
Hide comment
@ingenieroariel

ingenieroariel Feb 20, 2013

Member

When running this against the latest geonode master branch, which is running against the following geoexplorer revision: https://github.com/opengeo/suite/tree/57bb2fdd8469043b33f351ff0a0991b49a91cb4d/geoexplorer

I get this error:

Error: Could not create tool plugin with ptype: gxp_getfeedfeatureinfo
Member

ingenieroariel commented Feb 20, 2013

When running this against the latest geonode master branch, which is running against the following geoexplorer revision: https://github.com/opengeo/suite/tree/57bb2fdd8469043b33f351ff0a0991b49a91cb4d/geoexplorer

I get this error:

Error: Could not create tool plugin with ptype: gxp_getfeedfeatureinfo
@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Feb 20, 2013

Contributor

I don't think GeoExplorer was pegged to the new GXP version as yet

Contributor

bartvde commented Feb 20, 2013

I don't think GeoExplorer was pegged to the new GXP version as yet

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Feb 20, 2013

Contributor

Also this will never be in master, only in dev for the suite repo

Contributor

bartvde commented Feb 20, 2013

Also this will never be in master, only in dev for the suite repo

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Feb 20, 2013

Contributor

I've just pegged geoexplorer to the latest gxp in the suite's dev branch: boundlessgeo/suite@dc5e859

Contributor

bartvde commented Feb 20, 2013

I've just pegged geoexplorer to the latest gxp in the suite's dev branch: boundlessgeo/suite@dc5e859

@jj0hns0n

This comment has been minimized.

Show comment
Hide comment
@jj0hns0n

jj0hns0n Feb 20, 2013

Member

@ingenieroariel ... ball is back in your court I think. Let me know if you
need any help from our end before you are able to pull this.

Once this is in, can we go ahead and do an Alpha5 or should we just wait
until friday? Guess we can discuss on the meeting tomorrow.

On Wed, Feb 20, 2013 at 9:27 AM, Bart van den Eijnden <
notifications@github.com> wrote:

I've just pegged geoexplorer to the latest gxp in the suite's dev branch:
boundlessgeo/suite@dc5e859boundlessgeo/suite@dc5e859


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-13844630.

Member

jj0hns0n commented Feb 20, 2013

@ingenieroariel ... ball is back in your court I think. Let me know if you
need any help from our end before you are able to pull this.

Once this is in, can we go ahead and do an Alpha5 or should we just wait
until friday? Guess we can discuss on the meeting tomorrow.

On Wed, Feb 20, 2013 at 9:27 AM, Bart van den Eijnden <
notifications@github.com> wrote:

I've just pegged geoexplorer to the latest gxp in the suite's dev branch:
boundlessgeo/suite@dc5e859boundlessgeo/suite@dc5e859


Reply to this email directly or view it on GitHubhttps://github.com/GeoNode/geonode/pull/539#issuecomment-13844630.

allyoucanmap pushed a commit to allyoucanmap/geonode that referenced this pull request Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment