Skip to content

Display and save GeoRSS feeds as map layers #539

Closed
wants to merge 23 commits into from

5 participants

@mbertrand
GeoNode Development Team member

Pull request for GNIP 23 - Add GeoRSS Layers such as Picasa and Youtube Feeds

This functionality depends on another pull request for gxp - boundlessgeo/gxp#161 - where most of the changes were made.

@jj0hns0n
GeoNode Development Team member
@ahocevar
GeoNode Development Team member

In my opinion it is ok to accept contributions for gxp. We have done this before. So it is mostly a resourcing question to make sure there is time for reviews. Even better than doing reviews for large contributions when the code is already written would be to discuss them beforehand on the gxp list.

@jj0hns0n
GeoNode Development Team member
@jj0hns0n
GeoNode Development Team member
jj0hns0n commented Dec 6, 2012

@ahocevar and @bartvde what was the final story on this. Can we pull the stuff we need into GXP and reference it in our tree without having to do a custom geonode-client build in place?

@bartvde
bartvde commented Dec 6, 2012

Once the GXP PR gets merged, we will make sure all the dependencies are in GXP, just like we did for catalog search in add layers in the code sprint. @ahocevar was okay with this approach.

@ingenieroariel
GeoNode Development Team member

The GXP PR is closed and @mbertrand added some commits. Is this ready to be merged?

boundlessgeo/gxp#161

@mbertrand
GeoNode Development Team member
@jj0hns0n
GeoNode Development Team member
@mbertrand
GeoNode Development Team member

Hi @bartvde, what's the procedure now for adding additional gxp plugins/widgets that aren't included by default w/GeoExplorer?

@bartvde
bartvde commented Jan 16, 2013

@mbertrand the procedure is to add the dependencies at the GXP/GeoExplorer level

@mbertrand
GeoNode Development Team member
@bartvde
bartvde commented Jan 17, 2013

Yeah I would say just include them by default.

For GeoNode we don't have a good story right now since we got rid of the client, I think we would just use static script files there (and requirejs?)

@mbertrand
GeoNode Development Team member

Submitted another PR to gxp making YouTube and Picasa feed sources required instead of optional.

Not sure if this is a bug or by design, but including additional tools in viewer config has no effect anymore, for example: https://github.com/cga-harvard/cga-worldmap/blob/95b4c19d1cc5bdffdaa5502b2484ba7774537343/geonode/maps/templates/maps/map_include.html#L9

@bartvde
bartvde commented Jan 18, 2013

See the discussion here: boundlessgeo/suite#51 so yes this is by design.

I originally had this change but it got reverted: bartvde/suite@8ce590e

@ingenieroariel
GeoNode Development Team member

Adding a link to the PR in gxp for follow up:

boundlessgeo/gxp#178

@ingenieroariel
GeoNode Development Team member

The other pull request is already closed, @mbertrand please merge this one into master yourself ;)

@mbertrand
GeoNode Development Team member

@ingenieroariel, @bartvde, I will merge as soon as the gxp changes get into GeoNode's bundled GeoExplorer.js - I don't think they're there yet?

@ingenieroariel
GeoNode Development Team member
@jj0hns0n
GeoNode Development Team member
@ingenieroariel
GeoNode Development Team member

The updated geoexplorer is now in our codebase

@jj0hns0n
GeoNode Development Team member
@ingenieroariel
GeoNode Development Team member

When running this against the latest geonode master branch, which is running against the following geoexplorer revision: https://github.com/opengeo/suite/tree/57bb2fdd8469043b33f351ff0a0991b49a91cb4d/geoexplorer

I get this error:

Error: Could not create tool plugin with ptype: gxp_getfeedfeatureinfo
@bartvde
bartvde commented Feb 20, 2013

I don't think GeoExplorer was pegged to the new GXP version as yet

@bartvde
bartvde commented Feb 20, 2013

Also this will never be in master, only in dev for the suite repo

@bartvde
bartvde commented Feb 20, 2013

I've just pegged geoexplorer to the latest gxp in the suite's dev branch: boundlessgeo/suite@dc5e859

@jj0hns0n
GeoNode Development Team member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.