Pull request for GNIP 23 - Add GeoRSS Layers such as Picasa and Youtube Feeds
This functionality depends on another pull request for gxp - boundlessgeo/gxp#161 - where most of the changes were made.
initial port of feed layers/sources
Support for GeoRSS feed layers
Remove feed code from here because it may soon disappear
Add legend override for vector layers to geo_header.html; add javascr…
…ipt for feed select control to templates
Reset gxp submodule
In my opinion it is ok to accept contributions for gxp. We have done this before. So it is mostly a resourcing question to make sure there is time for reviews. Even better than doing reviews for large contributions when the code is already written would be to discuss them beforehand on the gxp list.
Get rid of unnecessary js call
@ahocevar and @bartvde what was the final story on this. Can we pull the stuff we need into GXP and reference it in our tree without having to do a custom geonode-client build in place?
Once the GXP PR gets merged, we will make sure all the dependencies are in GXP, just like we did for catalog search in add layers in the code sprint. @ahocevar was okay with this approach.
Merge branch 'dev' of https://github.com/GeoNode/geonode into devfeeds
No more modules
Wrong branch for paragraph
No more GeoExplorer
No more geonode-client build
Use prebuilt geoexplorer
The GXP PR is closed and @mbertrand added some commits. Is this ready to be merged?
Hi @bartvde, what's the procedure now for adding additional gxp plugins/widgets that aren't included by default w/GeoExplorer?
@mbertrand the procedure is to add the dependencies at the GXP/GeoExplorer level
Yeah I would say just include them by default.
For GeoNode we don't have a good story right now since we got rid of the client, I think we would just use static script files there (and requirejs?)
Merge remote-tracking branch 'origin/dev' into devfeeds
Redo feedsource integration
Undo debug change
Submitted another PR to gxp making YouTube and Picasa feed sources required instead of optional.
Not sure if this is a bug or by design, but including additional tools in viewer config has no effect anymore, for example: https://github.com/cga-harvard/cga-worldmap/blob/95b4c19d1cc5bdffdaa5502b2484ba7774537343/geonode/maps/templates/maps/map_include.html#L9
See the discussion here: boundlessgeo/suite#51 so yes this is by design.
I originally had this change but it got reverted: bartvde/suite@8ce590e
Load FeedGeatFeatureInfo tool to GeoExplorer.Viewer tools
Adding a link to the PR in gxp for follow up:
The other pull request is already closed, @mbertrand please merge this one into master yourself ;)
@ingenieroariel, @bartvde, I will merge as soon as the gxp changes get into GeoNode's bundled GeoExplorer.js - I don't think they're there yet?
The updated geoexplorer is now in our codebase
When running this against the latest geonode master branch, which is running against the following geoexplorer revision: https://github.com/opengeo/suite/tree/57bb2fdd8469043b33f351ff0a0991b49a91cb4d/geoexplorer
I get this error:
Error: Could not create tool plugin with ptype: gxp_getfeedfeatureinfo
I don't think GeoExplorer was pegged to the new GXP version as yet
Also this will never be in master, only in dev for the suite repo
I've just pegged geoexplorer to the latest gxp in the suite's dev branch: boundlessgeo/suite@dc5e859
Support for GeoRSS feeds, Closes #539