Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Full-width cards in timelines, a'la 0.3.x #501

Open
3 of 4 tasks
algernon opened this issue Sep 13, 2023 · 6 comments
Open
3 of 4 tasks

[Request]: Full-width cards in timelines, a'la 0.3.x #501

algernon opened this issue Sep 13, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@algernon
Copy link

Describe the request

I'm using Tuba on the desktop, vertically maximized, horizontally half-screen, clamped to the left of my second monitor. I found this to be a great setup, things are just the right size, and there's not much wasted screen space, while there remains ample spacing to not feel crowded.

In 0.3.0, this is how my home timeline looked:

Screenshot from 2023-09-13 09-03-06

Unfortunately, in 0.4.1, it looks like this:

Screenshot from 2023-09-13 09-03-29

There's a lot more of wasted space, and the greyish background of the list looks a bit awkward. Further experimenting revealed that 0.3.0 had this same card view when the window size was bigger (like full width, I have not tried to find the breakpoint yet), so I suppose this is a breakpoint change. Similarly, if I make my window on 0.4.1 a tiny bit narrower, Tuba goes back to the 0.3.0 way of displaying the timeline:

Screenshot from 2023-09-13 09-40-44

I liked the 0.3.0 look a lot better. Is there a way to get that back? Or make it an option? Or, failing that, any local changes I could apply so that the statuses in timelines (and any other view that shows statuses, really) fill their containers? Preferably without having to fiddle with my window size... I can do that (thanks devilspie2!), but would really, really like to have it half-screen width. Makes it easier to line up something else on the other half.

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@algernon algernon added the enhancement New feature or request label Sep 13, 2023
@bragefuglseth
Copy link

The reason this has happened is likely because the sidebar has gotten narrower, which has made the content view so wide that it goes out of the full-width mode. This has most likely changed once again in the most recent release, 0.5.0. I imagine the only potential solution to this is to adjust the point at which the app enters/exits the full-width mode.

@algernon
Copy link
Author

Is there a way to adjust that breakpoint? Is it something set by Tuba, or something inherited from GTK/libadwaita/whatever-is-responsible?

If it is set by Tuba, would it be possible to make it configurable? I'm happy to try my hands at implementing that, but would need a pointer to where to start looking for it in the first place.

@bragefuglseth
Copy link

bragefuglseth commented Sep 23, 2023

This breakpoint is managed by Tuba. If it’s a problem, it should be solved by default, for everyone. It’s not worth spending a preference on.

@algernon
Copy link
Author

Awesome, then it's easier to fix! I think it would make sense to have full-width toots when the Tuba window half-width (or smaller), and start doing the card-like stuff when it is bigger? That would certainly work for me. It might not for screens wider than mine (I'm at 1920x1080), which is why I thought it might make sense to make it a preference.

To be honest, I'd be fine with having it stay the way it is, as long as I can override the breakpoint somehow, without recompiling Tuba.

In the meantime, where is it in Tuba? I'd like to patch it for myself quickly, until a proper solution is found. O:)

@GeopJr
Copy link
Owner

GeopJr commented Sep 24, 2023

You probably want to change these two to something like 800

Tuba/data/ui/views/base.ui

Lines 161 to 162 in f702912

<property name="maximum_size">670</property>
<property name="tightening_threshold">670</property>

Keep in mind that you are reaching an unsupported territory. Styles, widgets and layouts have been made for the default values and Tuba might not look quite right. You can edit it without recompiling Tuba by using gresource extract and glib-compile-resources but likewise, no further support will be given and it might get overwritten or break future Tuba releases.

image

@algernon
Copy link
Author

Thank you! I understand it's unsupported territory, and I'm fine with that. Now that I know where to look, and what to change, I can keep my changes updated if need be.

As far as I'm concerned, this resolves my issue, so you can close it if this isn't something you want to change. I'm happy with the workaround, even if it's unsupported territory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants