Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parmap API to remove DeprecationWarnings #7

Closed
wants to merge 6 commits into from

Conversation

@zeehio
Copy link

@zeehio zeehio commented Nov 10, 2017

Hi,

parmap 1.5.0 introduced support for passing keyword arguments to mapped functions. The drawback of this feature is that a consistent naming of parmap arguments is needed in order to prevent conflicts
between parmap arguments and user-defined arguments. The new parmap convention is to prefix all its arguments with "pm_" (for parmap) as documented http://parmap.readthedocs.io/en/latest/

This commit updates the sifra parmap calls to use the new API, removing the deprecation warnings that appear with parmap==1.5.1 (the parmap version used).

It also upgrades the requirements.txt file, as older parmap versions below 1.5.0 do not accept the new API.

Feel free to merge this pull request if you see fit.

Best,

Sergio parmap author

Brett Walker and others added 6 commits Nov 9, 2017
parmap 1.5.0 introduced support for passing keyword arguments to
mapped functions. The drawback of this feature is that a consistent
naming of parmap arguments is needed in order to prevent conflicts
between parmap arguments and user-defined arguments. The new parmap
convention is to prefix all its arguments with "pm_" (for parmap)
as documented http://parmap.readthedocs.io/en/latest/

This commit updates the sifra parmap calls to use the new API,
removing the deprecation warnings that appear with
parmap==1.5.1 (the parmap version used).

It also upgrades the requirements.txt file, as parmap >= 1.5.0
is now required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants