From 5ea0b4abb60e4bd6cc40b4852a882ea9e480bbff Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Mon, 25 Apr 2022 07:48:43 +0200 Subject: [PATCH] Suppress unused method errors flagged by error prone The most recent Bazel version is flagging assisted inject methods as unused. Details: https://github.com/google/error-prone/issues/3174 Release-Notes: skip Change-Id: Ibcdb2e509c8a48a9dd0824eddaf09f519d1959c1 --- java/com/google/gerrit/server/git/MultiProgressMonitor.java | 1 + java/com/google/gerrit/server/notedb/ChangeDraftUpdate.java | 1 + java/com/google/gerrit/server/notedb/ChangeUpdate.java | 1 + java/com/google/gerrit/server/notedb/RobotCommentUpdate.java | 2 ++ java/com/google/gerrit/server/rules/PrologRuleEvaluator.java | 1 + 5 files changed, 6 insertions(+) diff --git a/java/com/google/gerrit/server/git/MultiProgressMonitor.java b/java/com/google/gerrit/server/git/MultiProgressMonitor.java index 52a34d96b71e..290e1e7972f9 100644 --- a/java/com/google/gerrit/server/git/MultiProgressMonitor.java +++ b/java/com/google/gerrit/server/git/MultiProgressMonitor.java @@ -249,6 +249,7 @@ MultiProgressMonitor create( * @param out stream for writing progress messages. * @param taskName name of the overall task. */ + @SuppressWarnings("UnusedMethod") @AssistedInject private MultiProgressMonitor( CancellationMetrics cancellationMetrics, diff --git a/java/com/google/gerrit/server/notedb/ChangeDraftUpdate.java b/java/com/google/gerrit/server/notedb/ChangeDraftUpdate.java index 5d19205a90eb..73161d7e380a 100644 --- a/java/com/google/gerrit/server/notedb/ChangeDraftUpdate.java +++ b/java/com/google/gerrit/server/notedb/ChangeDraftUpdate.java @@ -92,6 +92,7 @@ private static Key key(HumanComment c) { private List put = new ArrayList<>(); private Map delete = new HashMap<>(); + @SuppressWarnings("UnusedMethod") @AssistedInject private ChangeDraftUpdate( @GerritPersonIdent PersonIdent serverIdent, diff --git a/java/com/google/gerrit/server/notedb/ChangeUpdate.java b/java/com/google/gerrit/server/notedb/ChangeUpdate.java index e7de644bec6f..85bb445ae531 100644 --- a/java/com/google/gerrit/server/notedb/ChangeUpdate.java +++ b/java/com/google/gerrit/server/notedb/ChangeUpdate.java @@ -181,6 +181,7 @@ ChangeUpdate create( private DeleteChangeMessageRewriter deleteChangeMessageRewriter; private List submitRequirementResults; + @SuppressWarnings("UnusedMethod") @AssistedInject private ChangeUpdate( @GerritPersonIdent PersonIdent serverIdent, diff --git a/java/com/google/gerrit/server/notedb/RobotCommentUpdate.java b/java/com/google/gerrit/server/notedb/RobotCommentUpdate.java index edf5bd36cb09..7f067f569b66 100644 --- a/java/com/google/gerrit/server/notedb/RobotCommentUpdate.java +++ b/java/com/google/gerrit/server/notedb/RobotCommentUpdate.java @@ -69,6 +69,7 @@ RobotCommentUpdate create( private List put = new ArrayList<>(); + @SuppressWarnings("UnusedMethod") @AssistedInject private RobotCommentUpdate( @GerritPersonIdent PersonIdent serverIdent, @@ -81,6 +82,7 @@ private RobotCommentUpdate( super(noteUtil, serverIdent, notes, null, accountId, realAccountId, authorIdent, when); } + @SuppressWarnings("UnusedMethod") @AssistedInject private RobotCommentUpdate( @GerritPersonIdent PersonIdent serverIdent, diff --git a/java/com/google/gerrit/server/rules/PrologRuleEvaluator.java b/java/com/google/gerrit/server/rules/PrologRuleEvaluator.java index ddc3fcafedeb..cab5b458ce7c 100644 --- a/java/com/google/gerrit/server/rules/PrologRuleEvaluator.java +++ b/java/com/google/gerrit/server/rules/PrologRuleEvaluator.java @@ -98,6 +98,7 @@ private static class UserTermExpected extends Exception { private final PrologOptions opts; private Term submitRule; + @SuppressWarnings("UnusedMethod") @AssistedInject private PrologRuleEvaluator( AccountCache accountCache,