New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad documentation in dkan_dataset_content_types.api.php #1721

Closed
oriole9g opened this Issue Feb 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@oriole9g
Contributor

oriole9g commented Feb 17, 2017

In this file you can read:

/**
** Removes a set of license options for the dkan dataset license field.
**
*/
function hook_license_subscribe() {

The hook example should be unsubscribe not subscribe

Plus, the documentation generated here: https://media.readthedocs.org/pdf/dkan/latest/dkan.pdf it's not correct. In page 22 says:

// Let's asume we want to do this as part of the fictitious license_options_extra module
function license_options_extra_unsubscribe() {
return array(
'notspecified',
)
}

This doesn't work, if you create a module named license_options_extra the hook should be license_options_extra_license_unsubscribe

@dafeder

This comment has been minimized.

Show comment
Hide comment
@dafeder

dafeder Feb 24, 2017

Member

Thanks @oriole9g - PRs appreciated if you are inspired, otherwise we'll fix for a future release.

Member

dafeder commented Feb 24, 2017

Thanks @oriole9g - PRs appreciated if you are inspired, otherwise we'll fix for a future release.

@oriole9g

This comment has been minimized.

Show comment
Hide comment
@oriole9g

oriole9g Mar 7, 2017

Contributor
Contributor

oriole9g commented Mar 7, 2017

@janette

This comment has been minimized.

Show comment
Hide comment
@janette

janette Apr 6, 2017

Member

#1841 re-roll of #1774

Member

janette commented Apr 6, 2017

#1841 re-roll of #1774

@janette

This comment has been minimized.

Show comment
Hide comment
@janette

janette Jul 11, 2017

Member

fixed

Member

janette commented Jul 11, 2017

fixed

@janette janette closed this Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment