New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dkan modules downloaded via drush make to their own folder #824

Closed
frankcarey opened this Issue Dec 16, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@frankcarey
Contributor

frankcarey commented Dec 16, 2015

There are 2 reasons for moving the "drush-make-downloaded" dkan modules into their own folders.

  1. It's confusing when looking in that directory which are which. The .gitignore hides this too, making it even more difficult to know.

  2. Drush make has an --overwrite flag which we should use instead of having to delete dkan module folders individually. However, the logic isn't perfect, and drupal ends up removing the entire dkan folder, such that you need to use git checkout to get them back.

I propose to move "make-downloaded" dkan modules into modules/dkan-contrib folder instead of modules/dkan. Should be a simple fix.

In core dkan, these modules are:

  • dkan_dataset
  • dkan_datastore

But data_starter probably has more of them. It might make sense to put all projects NuCivic "controls" in that folder, which would make it easier to understand as well.

References:

drush-ops/drush#1450

keelahnkhan added a commit that referenced this issue Dec 17, 2015

@janette

This comment has been minimized.

Member

janette commented Jul 12, 2017

Done, view documentation here: http://dkan.readthedocs.io/en/latest/introduction/maintaining.html#adding-additional-modules-or-features

DKAN modules can be found in profiles/dkan/modules/dkan
and contrib modules can be found in profiles/dkan/modules/contrib

@janette janette closed this Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment