Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect to search page on 404 status #2576

Merged
merged 3 commits into from Jun 21, 2018
Merged

Add redirect to search page on 404 status #2576

merged 3 commits into from Jun 21, 2018

Conversation

janette
Copy link
Member

@janette janette commented Jun 20, 2018

Fixes #2484

Changes 404 behavior to produce a working search initially set to the bad URL. Also changes the header search box behavior to search whole site, not just datasets.

Steps to reproduce

  • Type in a url that does not exist, when on the 404 page, try to use the search block in the header
  • Confirm the search is not performed
  • Now go to an existing page, use the search block in the header
  • Confirm that the results are filtered to only include datasets

QA Steps

  • Type in a url that does not exist
  • Confirm that you are redirected to the search page
  • Confirm that the search block in the header works and does not limit results to datasets

@dafeder dafeder self-requested a review June 21, 2018 21:51
@dafeder dafeder merged commit 7342f71 into GetDKAN:7.x-1.x Jun 21, 2018
@janette janette mentioned this pull request Jun 28, 2019
3 tasks
dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Add redirect to search on 404

* Remove dataset filter on header search block

* Update search.feature
dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Add redirect to search on 404

* Remove dataset filter on header search block

* Update search.feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants