From 31bd9ee698029d7245d9b9155cee1ed89267192e Mon Sep 17 00:00:00 2001 From: jastraat Date: Mon, 15 May 2023 10:24:00 -0500 Subject: [PATCH 1/4] Remove unused distributions_tables variable and fallback to downloadURL when distribution title not set --- modules/metastore/metastore.theme.inc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/modules/metastore/metastore.theme.inc b/modules/metastore/metastore.theme.inc index 7fa13c02ab..29b65c45b6 100644 --- a/modules/metastore/metastore.theme.inc +++ b/modules/metastore/metastore.theme.inc @@ -97,13 +97,11 @@ function metastore_preprocess_node__data(&$variables) { ]; } } + // Fallback to display file path for link title. + if ($rows['downloadURL'] && !property_exists($d, 'title')) { + $rows['title'] = $rows['downloadURL']; + } $variables['dataset']['distributions'][] = $rows; - $variables['dataset']['distributions_tables'][] = [ - '#type' => 'table', - '#caption' => $d->title, - '#header' => [t("Key"), t("Value")], - '#rows' => $rows, - ]; } } } From 975612eba32ae81e1f7c7e8d88ef85176e27b4cf Mon Sep 17 00:00:00 2001 From: jastraat Date: Mon, 15 May 2023 10:38:42 -0500 Subject: [PATCH 2/4] =?UTF-8?q?Don=E2=80=99t=20call=20json=5Fdecode=20on?= =?UTF-8?q?=20null=20-=20when=20there=20is=20no=20form=20value?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/Plugin/Field/FieldWidget/JsonFormWidget.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/json_form_widget/src/Plugin/Field/FieldWidget/JsonFormWidget.php b/modules/json_form_widget/src/Plugin/Field/FieldWidget/JsonFormWidget.php index c7de03d1bc..8e55047482 100644 --- a/modules/json_form_widget/src/Plugin/Field/FieldWidget/JsonFormWidget.php +++ b/modules/json_form_widget/src/Plugin/Field/FieldWidget/JsonFormWidget.php @@ -114,7 +114,9 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen $default_data = []; // Get default data. foreach ($items as $item) { - $default_data = json_decode($item->value); + if ($item->value) { + $default_data = json_decode($item->value); + } } $type = $this->getSchemaId($form_state); // Copy the item type to the entity. From 60fd07ed6b91e39eae79f42fd05b66782bb73162 Mon Sep 17 00:00:00 2001 From: jastraat Date: Mon, 15 May 2023 10:39:01 -0500 Subject: [PATCH 3/4] =?UTF-8?q?Don=E2=80=99t=20check=20isValid=20on=20null?= =?UTF-8?q?=20url?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- modules/json_form_widget/src/Element/UploadOrLink.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/json_form_widget/src/Element/UploadOrLink.php b/modules/json_form_widget/src/Element/UploadOrLink.php index fc26ef22b5..d1f2318f1b 100644 --- a/modules/json_form_widget/src/Element/UploadOrLink.php +++ b/modules/json_form_widget/src/Element/UploadOrLink.php @@ -69,7 +69,7 @@ public static function processManagedFile(&$element, FormStateInterface $form_st $element = static::unsetFilesWhenRemoving($form_state->getTriggeringElement(), $element); $file_url_remote = isset($element['#value']['file_url_remote']) ? $element['#value']['file_url_remote'] : $element['#uri']; - $file_url_remote_is_valid = UrlHelper::isValid($file_url_remote, TRUE); + $file_url_remote_is_valid = isset($file_url_remote) && UrlHelper::isValid($file_url_remote, TRUE); $is_remote = $file_url_remote_is_valid && $file_url_type == static::TYPE_REMOTE; if ($is_remote) { $element = static::loadRemoteFile($element, $file_url_remote); From a3705de0073311464d3b3ba10f1cd9058c675198 Mon Sep 17 00:00:00 2001 From: jastraat Date: Mon, 15 May 2023 10:58:22 -0500 Subject: [PATCH 4/4] =?UTF-8?q?Don=E2=80=99t=20call=20cleanSelectId=20on?= =?UTF-8?q?=20an=20empty=20datetime=20property?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- modules/json_form_widget/src/ValueHandler.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/json_form_widget/src/ValueHandler.php b/modules/json_form_widget/src/ValueHandler.php index 025f80de43..f0964b1d9f 100644 --- a/modules/json_form_widget/src/ValueHandler.php +++ b/modules/json_form_widget/src/ValueHandler.php @@ -48,7 +48,7 @@ public function handleStringValues($formValues, $property) { if (isset($formValues[$property]['select'])) { return isset($formValues[$property][0]) ? $formValues[$property][0] : NULL; } - return !empty($formValues[$property]) ? $this->cleanSelectId($formValues[$property]) : FALSE; + return !empty($formValues[$property]) && is_string($formValues[$property]) ? $this->cleanSelectId($formValues[$property]) : FALSE; } /**