Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback errors do not get reported to the SDK client #92

Closed
jasenmoloy opened this issue Oct 4, 2019 · 3 comments

Comments

@jasenmoloy
Copy link

commented Oct 4, 2019

It looks like certain listeners do not allow the SDK client to handles errors. Specifically classes that implement within the SDK:

  • com.getstream.sdk.chat.storage.Storage.OnQueryListener
  • com.getstream.sdk.chat.rest.interfaces.QueryChannelListCallback

The anonymous classes that implement these interfaces don't provide a way to let the SDK client know when errors occur. Some are even marked as // TODO.

We need this functionality in order to report errors to users, debugging tools, retry, and/or alter our logic.

Some use cases that come to mind:

  • User has no network connectivity
  • Server is not responding
  • Latency is so high that we need to indicate to the user that we're in a loading state
@tschellenbach

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

@tschellenbach

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

@tbarbugli

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

#91 handles this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.