Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Retry logic when querying channels needs improvement/refactor #93
The anonymous class that is handling the callback for querying channels has retry logic when an error occurs.
The logic in this
This is related to #92 where it would be nice to inform the SDK client that an error occurs so we can present UI to the user that something went wrong.
Currently the lib does something reasonable by default but it is true that exposing retry logic makes a lot of sense.
The change is fairly small, I am just waiting for a PR to get merged before we get this one done.
@jasenmoloy @tschellenbach what do you think is the friendlies thing to do for the library? I was thinking maybe we allow you to pass something like an interceptor function with this signature:
My concern with having retry logic along with an exposed callback is the inflexibility. Depending on the error, we probably won't retry at all. Or we could present the user with a retry button if say they are in airplane mode.
Having retry logic in the library with an exposed callback also brings up more edge cases. For example, I don't see the