Skip to content

Conversation

@bpollman
Copy link
Contributor

@bpollman bpollman commented Oct 30, 2024

🔗 Issue Links

Provide all Jira tickets and/or Github issues related to this PR, if applicable.

🎯 Goal

Update mockDMChannel with parameter to set ownCapabilities in order to properly test test_chatChannelInfoVM_leaveButtonShownInDM in related PR
GetStream/stream-chat-swiftui#630

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@nuno-vieira
Copy link
Member

Thank you! @bpollman

@nuno-vieira nuno-vieira merged commit c25892d into GetStream:develop Oct 31, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants