Introduce test for the StreamEndpointErrorInterceptor and some parsing tests
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
gpunto
reviewed
Sep 25, 2025
Comment on lines
59
to
63
| val json = adapter.toJson(request) | ||
| val decoded = adapter.fromJson(json)!! | ||
|
|
||
| // Then | ||
| assertEquals(request, decoded) |
Collaborator
There was a problem hiding this comment.
If somebody renames/removes a property or adds a default, this test will still pass because the output (decoded) changes according to the input (request). E.g. if I rename language to lang, both will contain lang and still match.
Compilation breaks if changing the properties (without using android studio refactoring), but that's true regardless of the test doing serialization + deserialization.
Collaborator
Author
There was a problem hiding this comment.
This is correct. Let me update the tests. The goal is to not blindly change the models or the annotated fields.
...va/io/getstream/android/core/internal/http/interceptor/StreamEndpointErrorInterceptorTest.kt
Show resolved
Hide resolved
gpunto
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal is to introduce tests for the un-tested
StreamEndpointErrorInterceptor. Additional tests for the parsers are added.The parser tests may seam meaningless, but by round-tripping each internal model through
Moshiwe prove the generated adapters still match the JSON written/read by the socket session. If someone tweaks a field name, changes a default, or removes a property, the test breaks instead of the change sneaking into production (which has happened before).This is more so important because these models are not generated by any OpenAPI, but rather handwritten here.
Implementation
2 new test suits.
Testing
Tests should pass.
Checklist