Add connection recovery handler and lifecycle monitor #28

aleksandar-apostolov · 2025-11-21T09:45:10Z

Goal

Ensure the connection recovery evaluator reconnects in the intended lifecycle/network scenarios and add coverage for the lifecycle/recovery/subscribe helper packages that were previously untested.

Implementation

Implemented StreamConnectionRecoveryEvaluatorImpl to gate reconnection on prior connectivity, foreground lifecycle, and either a returning-to-foreground or newly available network signal while persisting the last usable snapshot for reconnect attempts.
Added a comprehensive test suite for the evaluator
Introduced tests for StreamLifecycleMonitor

Testing

Run the sample and go into background foreground. Check the logs to see if you are correctly disconnected then connected.

Checklist

Issue linked (if any)
Tests/docs updated
I have signed the Stream CLA (https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform) (required for
external contributors)

…add tests

# Conflicts: # app/src/main/java/io/getstream/android/core/sample/SampleActivity.kt # app/src/main/java/io/getstream/android/core/sample/client/StreamClient.kt # app/src/main/java/io/getstream/android/core/sample/ui/ConnectionStateCard.kt # app/src/main/java/io/getstream/android/core/sample/ui/NetworkInfoCard.kt # app/src/main/java/io/getstream/android/core/sample/ui/NetworkInfoComponents.kt # gradle/libs.versions.toml # stream-android-core/build.gradle.kts # stream-android-core/src/main/AndroidManifest.xml # stream-android-core/src/main/java/io/getstream/android/core/api/StreamClient.kt # stream-android-core/src/main/java/io/getstream/android/core/api/components/StreamAndroidComponentsProvider.kt # stream-android-core/src/main/java/io/getstream/android/core/api/model/connection/network/StreamNetworkInfo.kt # stream-android-core/src/main/java/io/getstream/android/core/api/model/connection/network/StreamNetworkState.kt # stream-android-core/src/main/java/io/getstream/android/core/api/observers/network/StreamNetworkMonitor.kt # stream-android-core/src/main/java/io/getstream/android/core/api/observers/network/StreamNetworkMonitorListener.kt # stream-android-core/src/main/java/io/getstream/android/core/api/socket/monitor/StreamHealthMonitor.kt # stream-android-core/src/main/java/io/getstream/android/core/api/utils/Algebra.kt # stream-android-core/src/main/java/io/getstream/android/core/internal/client/StreamClientImpl.kt # stream-android-core/src/main/java/io/getstream/android/core/internal/components/StreamAndroidComponentsProviderImpl.kt # stream-android-core/src/main/java/io/getstream/android/core/internal/observers/network/StreamNetworkMonitorCallback.kt # stream-android-core/src/main/java/io/getstream/android/core/internal/observers/network/StreamNetworkMonitorImpl.kt # stream-android-core/src/main/java/io/getstream/android/core/internal/observers/network/StreamNetworkMonitorUtils.kt # stream-android-core/src/main/java/io/getstream/android/core/internal/observers/network/StreamNetworkSignalProcessing.kt # stream-android-core/src/main/java/io/getstream/android/core/internal/observers/network/StreamNetworkSnapshotBuilder.kt # stream-android-core/src/test/java/io/getstream/android/core/api/StreamClientFactoryTest.kt # stream-android-core/src/test/java/io/getstream/android/core/api/components/StreamAndroidComponentsProviderLatestApiTest.kt # stream-android-core/src/test/java/io/getstream/android/core/api/components/StreamAndroidComponentsProviderLegacyApiTest.kt # stream-android-core/src/test/java/io/getstream/android/core/api/observers/network/StreamNetworkMonitorFactoryTest.kt # stream-android-core/src/test/java/io/getstream/android/core/api/observers/network/StreamNetworkMonitorListenerTest.kt # stream-android-core/src/test/java/io/getstream/android/core/api/utils/AlgebraTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/client/StreamClientIImplTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkMonitorCallbackTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkMonitorImplTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkMonitorUtilsTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkSignalProcessingLatestApiTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkSignalProcessingLegacyApiTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkSignalProcessingTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkSnapshotBuilderLatestApiTest.kt # stream-android-core/src/test/java/io/getstream/android/core/internal/observers/network/StreamNetworkSnapshotBuilderLegacyApiTest.kt

github-actions · 2025-11-21T10:01:50Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

Copilot

Pull request overview

This pull request implements connection recovery handling and lifecycle monitoring for the Stream Android core SDK. The changes introduce a sophisticated system that manages WebSocket reconnection based on network availability and app lifecycle state (foreground/background), ensuring the client only attempts to reconnect when appropriate conditions are met.

Key Changes

Connection Recovery Evaluator: Implements StreamConnectionRecoveryEvaluatorImpl that evaluates connection, lifecycle, and network states to determine when to reconnect or disconnect, persisting the last known network snapshot for reconnection attempts.
Lifecycle Monitoring: Adds StreamLifecycleMonitor to track app foreground/background transitions using AndroidX ProcessLifecycleOwner.
Coordinated State Management: Introduces StreamNetworkAndLifeCycleMonitor to bridge network and lifecycle signals, providing a unified view for connection recovery decisions.

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`StreamConnectionRecoveryEvaluatorImpl.kt`	Core logic for evaluating when to reconnect/disconnect based on state transitions
`StreamLifecycleMonitorImpl.kt`	Monitors app lifecycle events and notifies registered listeners
`StreamNetworkAndLifecycleMonitorImpl.kt`	Combines network and lifecycle monitoring into a single coordinator
`StreamClientImpl.kt`	Refactored to use recovery evaluator and lifecycle monitoring; added token retry logic
`ForEach.kt`	Helper extension for invoking suspending blocks over subscription listeners
`Result.kt`	Added `onTokenError` extension for handling authentication token errors
`Flows.kt`	Utility for updating MutableStateFlow values
`StreamObservable.kt`	New interface extracting subscription pattern from `StreamSubscriptionManager`
Test files	Comprehensive test coverage for recovery evaluator, lifecycle monitor, and integration scenarios
`build.gradle.kts`	Added AndroidX lifecycle dependencies
`AndroidManifest.xml`	Added ACCESS_WIFI_STATE permission

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

stream-android-core/src/main/java/io/getstream/android/core/internal/subscribe/utils/ForEach.kt

stream-android-core/src/main/java/io/getstream/android/core/api/utils/Result.kt

...rc/test/java/io/getstream/android/core/api/observers/lifecycle/StreamLifecycleMonitorTest.kt

...c/main/java/io/getstream/android/core/internal/observers/StreamNetworkAndLifeCycleMonitor.kt

gpunto

I'm seeing this in the sample:

Launch it and then go in background
In some cases, I get a socket failure in background due to java.net.SocketException: Software caused connection abort
Then I get the corresponding state [notifyState] Notifying state: Disconnected(cause=java.net.SocketException: Software caused connection abort)
And then, if I resume the app, it gets stuck, i.e. no more logging occurs and I get an ANR, so the main thread seems to be blocked

In other cases, the failure at step 2 doesn't occur and the socket is reconnected, i.e. I get Notifying state: Connected(..., but still the app is stuck.

forEachSuspend might be a candidate, but I'm not sure if it's that or something else.

gradle/scripts/sonar.gradle

stream-android-core/src/main/java/io/getstream/android/core/api/utils/Result.kt

...in/java/io/getstream/android/core/internal/observers/network/StreamNetworkMonitorCallback.kt

stream-android-core/src/main/java/io/getstream/android/core/internal/subscribe/utils/ForEach.kt

gradle/scripts/sonar.gradle

...in/java/io/getstream/android/core/internal/recovery/StreamConnectionRecoveryEvaluatorImpl.kt

…ternal/recovery/StreamConnectionRecoveryEvaluatorImpl.kt Co-authored-by: Gianmarco <47775302+gpunto@users.noreply.github.com>

…i/utils/Result.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ternal/observers/StreamNetworkAndLifeCycleMonitor.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ses runBlocking

…o connection-recovery-handler

Copilot

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

stream-android-core/src/main/java/io/getstream/android/core/api/utils/Result.kt

stream-android-core/src/main/java/io/getstream/android/core/internal/client/StreamClientImpl.kt

…ternal/client/StreamClientImpl.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ternal/recovery/StreamConnectionRecoveryEvaluatorImpl.kt Co-authored-by: Gianmarco <47775302+gpunto@users.noreply.github.com>

sonarqubecloud · 2025-11-26T11:21:47Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

app/src/main/java/io/getstream/android/core/sample/SampleActivity.kt

aleksandar-apostolov added 29 commits October 16, 2025 11:15

Add new network monitor and network sample UI in core

a8c599e

Spotless

6cee404

Update test

078cb67

Missing permission check

edac873

Missing permission check

b25c1a3

Add tests for the stream network monitor utils and processing

4b54265

Move network monitor initialization after connection is established, …

bf78bb9

…add tests

Stop network monitor on Disconnect

c010b50

Refactor the callback into separate delegate and add tests

e945bfa

Fix lint errors and run spotless

fce3cfa

Refactor snapshot builder and add tests

3ff9bb1

Refactor signal processing and add tests

dd99226

Add more tests

c9f8003

Spotless

d1188f6

Fix algebra

b91fcdc

Update wrapper is now more generic

77f24ef

Spotless

693328e

Change state update mechanism

e0e234c

Spotless

c2c3cef

Update network info UI in sample

3b30b03

Update client test

bace614

Spotless

f484eb4

Move update helper in a separate class

885d450

Spotless

3bed610

Connection recovery handler and monitors

c1e5668

Add more tests

08363ed

Remove onNetworkState method

836e574

Merged devop and reformatted

5a0b34e

aleksandar-apostolov changed the title ~~Add connection recovery handler~~ Add connection recovery handler and lifecycle monitor Nov 21, 2025

aleksandar-apostolov added 6 commits November 21, 2025 11:17

Spotless

3dd800b

add tests

2c86894

add tests

90c3538

Update sonar paths

f0a0e45

Update coverage parts

3e0986b

Spotless and koverXmlReport dependency for sonar

d176eab

aleksandar-apostolov requested review from Copilot and gpunto November 25, 2025 09:11

Copilot started reviewing on behalf of aleksandar-apostolov November 25, 2025 09:12 View session

Copilot finished reviewing on behalf of aleksandar-apostolov November 25, 2025 09:14

Copilot AI reviewed Nov 25, 2025

View reviewed changes

gpunto reviewed Nov 25, 2025

View reviewed changes

aleksandar-apostolov and others added 5 commits November 26, 2025 11:32

Update stream-android-core/src/main/java/io/getstream/android/core/in…

d4e2a2b

…ternal/recovery/StreamConnectionRecoveryEvaluatorImpl.kt Co-authored-by: Gianmarco <47775302+gpunto@users.noreply.github.com>

Update stream-android-core/src/main/java/io/getstream/android/core/ap…

f20e65d

…i/utils/Result.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update stream-android-core/src/main/java/io/getstream/android/core/in…

41cbf28

…ternal/observers/StreamNetworkAndLifeCycleMonitor.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove forEachSuspend as it breaks the async functionality since it u…

ac231f8

…ses runBlocking

Merge remote-tracking branch 'origin/connection-recovery-handler' int…

7334c00

…o connection-recovery-handler

aleksandar-apostolov requested review from Copilot and gpunto November 26, 2025 10:58

Copilot started reviewing on behalf of aleksandar-apostolov November 26, 2025 10:59 View session

Copilot finished reviewing on behalf of aleksandar-apostolov November 26, 2025 11:01

Copilot AI reviewed Nov 26, 2025

View reviewed changes

stream-android-core/src/main/java/io/getstream/android/core/api/utils/Result.kt Outdated Show resolved Hide resolved

stream-android-core/src/main/java/io/getstream/android/core/internal/client/StreamClientImpl.kt Outdated Show resolved Hide resolved

aleksandar-apostolov and others added 3 commits November 26, 2025 12:10

Update stream-android-core/src/main/java/io/getstream/android/core/in…

398e9d1

…ternal/client/StreamClientImpl.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update stream-android-core/src/main/java/io/getstream/android/core/in…

a0a25d3

…ternal/recovery/StreamConnectionRecoveryEvaluatorImpl.kt Co-authored-by: Gianmarco <47775302+gpunto@users.noreply.github.com>

Spotless & condition update

faca6d8

gpunto approved these changes Nov 26, 2025

View reviewed changes

app/src/main/java/io/getstream/android/core/sample/SampleActivity.kt Show resolved Hide resolved

aleksandar-apostolov merged commit 96731c4 into develop Nov 26, 2025
6 checks passed

aleksandar-apostolov deleted the connection-recovery-handler branch November 26, 2025 12:43

Add connection recovery handler and lifecycle monitor #28

Add connection recovery handler and lifecycle monitor #28

Uh oh!

Conversation

aleksandar-apostolov commented Nov 21, 2025

Goal

Implementation

Testing

Checklist

Uh oh!

github-actions bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gpunto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 26, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 21, 2025 •

edited

Loading