Skip to content

Conversation

@gpunto
Copy link
Collaborator

@gpunto gpunto commented Nov 27, 2025

Goal

Found the issue. I hadn't actually applied the convention plugin to the lint module 🤦‍♂️

Implementation

  • Apply the plugin to the lint module
  • Apply Spotless, since now also that convention is applied to the module

Testing

I tested in a local sonarqube instance. With this, the module will stop appearing in sonar altogether.

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@gpunto gpunto requested a review from Copilot November 27, 2025 09:58
@gpunto gpunto added the pr:ci CI changes label Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

Copilot finished reviewing on behalf of gpunto November 27, 2025 10:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the stream.java.library convention plugin was not properly applied to the lint module due to missing alias() function syntax. With the plugin now correctly applied, the sonar coverage exclusion for the lint module has been appropriately removed.

  • Fixed plugin application syntax in stream-android-core-lint/build.gradle.kts by adding the missing alias() wrapper
  • Removed sonar coverage exclusions for lint modules now that the convention plugin is properly applied

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
stream-android-core-lint/build.gradle.kts Corrected plugin application from libs.plugins.stream.java.library to alias(libs.plugins.stream.java.library) to properly apply the convention plugin
build.gradle.kts Removed sonar coverage exclusions for lint modules since the convention plugin is now correctly applied

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@sonarqubecloud
Copy link

@gpunto gpunto marked this pull request as ready for review November 27, 2025 10:51
@aleksandar-apostolov aleksandar-apostolov merged commit 7a62c39 into develop Nov 27, 2025
7 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the fix-plugin-application branch November 27, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants