Feature: keep feed own capabilities up to date #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add middleware support to StateLayerEventPublisher * Add own capabilities middleware which enriches incoming WS events and extracts and stores own capabilities from local events * State layer explicitly saves own capabilities from get or query methods which do not post local events
laevandus
commented
Nov 13, 2025
|
|
||
| let user: UserData | ||
| let ownCapabilities: [FeedOwnCapability] | ||
| let ownCapabilities: Set<FeedOwnCapability> |
laevandus
commented
Nov 13, 2025
Comment on lines
23
to
24
| /// A delay in seconds until feed own capabilities are fetched for feeds delivered through web-socket and there is no cached data available. | ||
| var automaticFeedOwnCapabilitiesFetchDelay: Int = 5 |
Contributor
Author
There was a problem hiding this comment.
Intentionally internal for now. Used by tests
Contributor
There was a problem hiding this comment.
this feels a bit unnecessary imo
Contributor
Author
There was a problem hiding this comment.
OK, I'll take it away and we can add that if it becomes a problem. It should be rare that it gets triggered often (only thinking about the timeline feed case where new activities can point at many other feeds). But event then, most probably the state is already cached.
laevandus
commented
Nov 13, 2025
Comment on lines
+64
to
+66
| func saveCapabilities(in feedData: FeedData?) -> [FeedId: Set<FeedOwnCapability>]? { | ||
| saveCapabilities(in: [feedData].compactMap { $0 }) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Convenience mostly for ActivityData.currentFeed (optional)
Generated by 🚫 Danger |
Public Interface public struct ActivityData: Identifiable, Equatable, Sendable
- public let currentFeed: FeedData?
+ public private var currentFeed: FeedData?
public struct FollowData: Equatable, Sendable
- public let sourceFeed: FeedData
+ public private var sourceFeed: FeedData
- public let targetFeed: FeedData
+ public private var targetFeed: FeedData
public struct BookmarkData: Equatable, Sendable
- public let activity: ActivityData
+ public private var activity: ActivityData
public struct FeedData: Identifiable, Equatable, Sendable
- public let ownCapabilities: [FeedOwnCapability]?
+ public private var ownCapabilities: Set<FeedOwnCapability>?
- public let ownFollows: [FollowData]?
+ public private var ownFollows: [FollowData]?
- public let ownMembership: FeedMemberData?
+ public private var ownMembership: FeedMemberData? |
Collaborator
SDK Size
|
|
Collaborator
StreamFeeds XCSize
Show 21 more objects
|
laevandus
commented
Nov 14, 2025
| case bodyType(Decodable.Type) | ||
| } | ||
|
|
||
| struct APIResponse { |
Contributor
Author
There was a problem hiding this comment.
We have tests where the order of requests is not serial, therefore a bit more sophisticated mocking is required. E.g. events can trigger capabilities fetch.
martinmitrevski
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Fixes: IOS-1236
🎯 Goal
Keep
FeedData.ownCapabilitiesup to date when handling web-socket events📝 Summary
Additional context: SDK has
StateLayerEventPublisherwhich publishes events from web-socket events and from API calls (StateLayerEventis an enum).Feed,FeedList,Activity,ActivityList,BookmarkList,FollowListStateLayerEventPublisherfeedOwnCapabilitiesUpdatedfor propagating this data)Feed,FeedList,Activity,ActivityList,BookmarkList,FollowListActivity.currentFeed.ownCapabilitiesis nil).🛠 Implementation
Agreement was that, although local caching and updating is not ideal, there is not a viable way to workaround it on the backend side.
🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo