Add activity batch update event for updating state with activity batch operations #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public func addActivity(request: AddActivityRequest) async throws -> ActivityData { | ||
| let activityData = try await activitiesRepository.addActivity(request: request) | ||
| for feed in request.feeds.map(FeedId.init) { | ||
| await stateLayerEventPublisher.sendEvent(.activityAdded(activityData, feed)) |
Contributor
There was a problem hiding this comment.
why do we need to do this? Shouldn't this come from the WS event?
Contributor
Author
There was a problem hiding this comment.
The same pattern is everywhere else as well. It is good because state is updated before this function returns.
I can write code where:
let feed = client.feed(for: )
try await client.addActivity(… )
let activities = feed.state.activities // this already contains added activities, WS event has not received
Secondly WS events do not have own_ fields set, so using HTTP response data we get the most up to date data for all the own fields as well.
martinmitrevski
approved these changes
Nov 14, 2025
# Conflicts: # CHANGELOG.md # Tests/StreamFeedsTests/StateLayer/ActivityList_Tests.swift # Tests/StreamFeedsTests/TestTools/ActivityResponse+Testing.swift
Generated by 🚫 Danger |
Public Interface public struct ModelUpdates: Sendable
- public let added: [Model]
+ public internal var added: [Model]
- public let removedIds: [String]
+ public internal var removedIds: Set<String>
- public let updated: [Model]
+ public internal var updated: [Model]
public final class FeedsClient: Sendable
- @discardableResult public func addActivity(request: AddActivityRequest)async throws -> AddActivityResponse
+ @discardableResult public func addActivity(request: AddActivityRequest)async throws -> ActivityData
- @discardableResult public func deleteActivities(request: DeleteActivitiesRequest)async throws -> DeleteActivitiesResponse
+ @discardableResult public func deleteActivities(request: DeleteActivitiesRequest)async throws -> Set<String> |
Collaborator
SDK Size
|
|
Collaborator
StreamFeeds XCSize
Show 9 more objects
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Fixes: IOS-1252
🎯 Goal
Activity batch operations did not update state-layer state
📝 Summary
activityBatchUpdatefor batch operations which also update state layer state with one go🛠 Implementation
Local events are good for state layer because these contain full data where as web-socket events lack own fields.
🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo