From 88363b98b58ba0f59bcfab13aa95ce9846d6bb9d Mon Sep 17 00:00:00 2001 From: Tiago Farto Date: Mon, 11 Mar 2024 12:20:44 +0000 Subject: [PATCH 1/4] chore: added param --- src/test/java/io/getstream/client/BatchClientTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/test/java/io/getstream/client/BatchClientTest.java b/src/test/java/io/getstream/client/BatchClientTest.java index 66c9bd15..420135df 100644 --- a/src/test/java/io/getstream/client/BatchClientTest.java +++ b/src/test/java/io/getstream/client/BatchClientTest.java @@ -150,9 +150,11 @@ public void partiallyUpdateActivitiesByForeignID() throws Exception { @Test public void getActivitiesByID() throws Exception { + Activity activity = Activity.builder().actor("test").verb("test").object("test").build(); + BatchClient client = Client.builder(apiKey, secret).build().batch(); - List result = client.getActivitiesByID("1657b300-a648-11d5-8080-800020fde6c3").join(); + List result = client.getActivitiesByID(activity.getID()).join(); } @Test @@ -160,7 +162,7 @@ public void getEnrichedActivitiesByID() throws Exception { BatchClient client = Client.builder(apiKey, secret).build().batch(); List result = - client.getEnrichedActivitiesByID("1657b300-a648-11d5-8080-800020fde6c3").join(); + client.getEnrichedActivitiesByID("5a4781d0-7a42-11ee-8080-8001056a0dad").join(); } @Test From e59ccf2085b88eaf8fa7ce689476530de780d76a Mon Sep 17 00:00:00 2001 From: Tiago Farto Date: Mon, 11 Mar 2024 17:12:19 +0000 Subject: [PATCH 2/4] chore: add with own children param --- .../io/getstream/client/ReactionsClient.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/io/getstream/client/ReactionsClient.java b/src/main/java/io/getstream/client/ReactionsClient.java index 074244ac..b840f908 100644 --- a/src/main/java/io/getstream/client/ReactionsClient.java +++ b/src/main/java/io/getstream/client/ReactionsClient.java @@ -73,40 +73,40 @@ public CompletableFuture> filter( public CompletableFuture> paginatedFilter(LookupKind lookup, String id) throws StreamException { return paginatedFilter( - lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, ""); + lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, "", false); } public CompletableFuture> paginatedFilter( LookupKind lookup, String id, Limit limit) throws StreamException { - return paginatedFilter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, ""); + return paginatedFilter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, "", false); } public CompletableFuture> paginatedFilter( LookupKind lookup, String id, Filter filter) throws StreamException { - return paginatedFilter(lookup, id, filter, DefaultOptions.DEFAULT_LIMIT, ""); + return paginatedFilter(lookup, id, filter, DefaultOptions.DEFAULT_LIMIT, "", false); } public CompletableFuture> paginatedFilter( LookupKind lookup, String id, String kind) throws StreamException { return paginatedFilter( - lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, kind); + lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, kind, false); } public CompletableFuture> paginatedFilter( LookupKind lookup, String id, Filter filter, Limit limit) throws StreamException { - return paginatedFilter(lookup, id, filter, limit, ""); + return paginatedFilter(lookup, id, filter, limit, "", false); } public CompletableFuture> paginatedFilter( LookupKind lookup, String id, Limit limit, String kind) throws StreamException { - return paginatedFilter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, kind); + return paginatedFilter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, kind, false); } public CompletableFuture> paginatedFilter( - LookupKind lookup, String id, Filter filter, Limit limit, String kind) + LookupKind lookup, String id, Filter filter, Limit limit, String kind, Boolean withOwnChildren) throws StreamException { final Token token = buildReactionsToken(secret, TokenAction.READ); - return reactions.paginatedFilter(token, lookup, id, filter, limit, kind); + return reactions.paginatedFilter(token, lookup, id, filter, limit, kind, withOwnChildren); } public CompletableFuture> paginatedFilter(String next) From 3dec8597dd255457dbfd5c15cddcc0b3253cfe63 Mon Sep 17 00:00:00 2001 From: Tiago Farto Date: Mon, 11 Mar 2024 17:30:21 +0000 Subject: [PATCH 3/4] chore: revert changes --- src/test/java/io/getstream/client/BatchClientTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/test/java/io/getstream/client/BatchClientTest.java b/src/test/java/io/getstream/client/BatchClientTest.java index 420135df..66c9bd15 100644 --- a/src/test/java/io/getstream/client/BatchClientTest.java +++ b/src/test/java/io/getstream/client/BatchClientTest.java @@ -150,11 +150,9 @@ public void partiallyUpdateActivitiesByForeignID() throws Exception { @Test public void getActivitiesByID() throws Exception { - Activity activity = Activity.builder().actor("test").verb("test").object("test").build(); - BatchClient client = Client.builder(apiKey, secret).build().batch(); - List result = client.getActivitiesByID(activity.getID()).join(); + List result = client.getActivitiesByID("1657b300-a648-11d5-8080-800020fde6c3").join(); } @Test @@ -162,7 +160,7 @@ public void getEnrichedActivitiesByID() throws Exception { BatchClient client = Client.builder(apiKey, secret).build().batch(); List result = - client.getEnrichedActivitiesByID("5a4781d0-7a42-11ee-8080-8001056a0dad").join(); + client.getEnrichedActivitiesByID("1657b300-a648-11d5-8080-800020fde6c3").join(); } @Test From 4291946b82c2ec2edb509655a4cbdec1fbf4c249 Mon Sep 17 00:00:00 2001 From: Tiago Farto Date: Mon, 11 Mar 2024 17:36:28 +0000 Subject: [PATCH 4/4] chore: added with own children parameter --- src/main/java/io/getstream/client/ReactionsClient.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/main/java/io/getstream/client/ReactionsClient.java b/src/main/java/io/getstream/client/ReactionsClient.java index b840f908..f61e4b3f 100644 --- a/src/main/java/io/getstream/client/ReactionsClient.java +++ b/src/main/java/io/getstream/client/ReactionsClient.java @@ -70,6 +70,13 @@ public CompletableFuture> filter( return reactions.filter(token, lookup, id, filter, limit, kind); } + public CompletableFuture> filter( + LookupKind lookup, String id, Filter filter, Limit limit, String kind, Boolean withOwnChildren) + throws StreamException { + final Token token = buildReactionsToken(secret, TokenAction.READ); + return reactions.filter(token, lookup, id, filter, limit, kind, withOwnChildren); + } + public CompletableFuture> paginatedFilter(LookupKind lookup, String id) throws StreamException { return paginatedFilter(