Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@v1
with:
dotnet-version: 5.0.x
dotnet-version: 6.0.x

- name: Dependency cache
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@v1
with:
dotnet-version: "5.0.x"
dotnet-version: "6.0.x"

- name: Create the package
run: dotnet pack --configuration Release ./src
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@v1
with:
dotnet-version: 5.0.x
dotnet-version: 6.0.x

- name: Reviewdog
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
dotnet build -clp:NoSummary -p:GenerateFullPaths=true --no-incremental --nologo -f net5.0 -v q src \
dotnet build -clp:NoSummary -p:GenerateFullPaths=true --no-incremental --nologo -f net6.0 -v q src \
| reviewdog -f=dotnet -name=dotnet -reporter=github-pr-review
10 changes: 9 additions & 1 deletion src/stream-net-tests/IntegrationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Newtonsoft.Json;
using Newtonsoft.Json.Serialization;
using Newtonsoft.Json.Linq;

namespace StreamNetTests
{
Expand Down Expand Up @@ -79,6 +81,10 @@ public async Task TestAddActivityWithArray()
{
var newActivity = new Stream.Activity("1", "test", "1");
newActivity.SetData("complex", new String[] { "tommaso", "thierry", "shawn" });
newActivity.SetData("special_json", new { StuffOneTwo = "thing" }, new JsonSerializer
{
ContractResolver = new DefaultContractResolver { NamingStrategy = new KebabCaseNamingStrategy() }
});
var response = await this._user1.AddActivity(newActivity);
Assert.IsNotNull(response);

Expand All @@ -94,6 +100,8 @@ public async Task TestAddActivityWithArray()
Assert.IsNotNull(complex);
Assert.AreEqual(3, complex.Length);
Assert.AreEqual("shawn", complex[2]);

Assert.AreEqual("thing", first.GetData<JObject>("special_json")["stuff-one-two"].Value<string>());
}

[Test]
Expand Down
4 changes: 2 additions & 2 deletions src/stream-net-tests/stream-net-tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<DefineConstants>TRACE;DEBUG;NETCORE</DefineConstants>
</PropertyGroup>
<PropertyGroup>
<TargetFrameworks>net5.0</TargetFrameworks>
<TargetFrameworks>net6.0</TargetFrameworks>
<IsPackable>false</IsPackable>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="4.1.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\stream-net\stream-net.csproj">
Expand Down
9 changes: 7 additions & 2 deletions src/stream-net/Activity.cs
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,14 @@ public T GetData<T>(string name)
return default(T);
}

public void SetData<T>(string name, T data)
public void SetData<T>(string name, T data) => SetData(name, data, null);

public void SetData<T>(string name, T data, JsonSerializer serializer)
{
_data[name] = JValue.FromObject(data);
if (serializer != null)
_data[name] = JValue.FromObject(data, serializer);
else
_data[name] = JValue.FromObject(data);
}

[JsonConstructor]
Expand Down
5 changes: 5 additions & 0 deletions src/stream-net/Collections.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ public void SetData<T>(string name, T data)
this._data.SetData<T>(name, data);
}

public void SetData<T>(string name, T data, JsonSerializer serializer)
{
this._data.SetData<T>(name, data, serializer);
}

public string Ref(string collectionName)
{
return Collections.Ref(collectionName, this);
Expand Down
9 changes: 7 additions & 2 deletions src/stream-net/EnrichedActivity.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,14 @@ public T GetData<T>(string name)
return default(T);
}

public void SetData<T>(string name, T data)
public void SetData<T>(string name, T data) => SetData(name, data, null);

public void SetData<T>(string name, T data, JsonSerializer serializer)
{
_data[name] = JValue.FromObject(data);
if (serializer != null)
_data[name] = JValue.FromObject(data, serializer);
else
_data[name] = JValue.FromObject(data);
}

[JsonConstructor]
Expand Down
9 changes: 7 additions & 2 deletions src/stream-net/GenericData.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,14 @@ public T GetData<T>(string name)
return this._data.TryGetValue(name, out val) ? val.ToObject<T>() : default(T);
}

public void SetData<T>(string name, T data)
public void SetData<T>(string name, T data) => SetData(name, data, null);

public void SetData<T>(string name, T data, JsonSerializer serializer)
{
this._data[name] = JValue.FromObject(data);
if (serializer != null)
_data[name] = JValue.FromObject(data, serializer);
else
_data[name] = JValue.FromObject(data);
}

internal JObject ToJObject()
Expand Down
2 changes: 1 addition & 1 deletion src/stream-net/stream-net.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<DefineConstants>TRACE;DEBUG;NETCORE</DefineConstants>
</PropertyGroup>
<PropertyGroup>
<TargetFrameworks>net45;net46;net47;net48;netstandard1.6;netstandard2.0;netstandard2.1;net5.0</TargetFrameworks>
<TargetFrameworks>net45;net46;net47;net48;netstandard1.6;netstandard2.0;netstandard2.1;net5.0;net6.0</TargetFrameworks>
</PropertyGroup>
<PropertyGroup>
<PackageId>stream-net</PackageId>
Expand Down