fix(noise cancellation): delay toggling until initialization is finished #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- await ready promise before enabling /disabling
oliverlaz
changed the title
- fix race condition
oliverlaz
approved these changes
Nov 24, 2025
santhoshvai
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
This PR fixes a race condition where setEnabled could run before the Krisp SDK was fully initialized. In that use-case the filter node exists but the promise is not yet resolved which leads to potential
WASM_OR_WORKER_NOT_READYerrors.With these changes toggle actions now wait for the initialization promise to resolve before executing.
🎫 Ticket: https://linear.app/stream/issue/REACT-667/krisp-delay-toggling-until-initialization-is-finished