Skip to content

[Fix]CallKit accepted events should be handled only for the current user #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 28, 2025
Merged

[Fix]CallKit accepted events should be handled only for the current user #733

merged 8 commits into from
Mar 28, 2025

Conversation

@ipavlidakis
Copy link
Contributor

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-767/[callkit]callaccepted-events-should-be-handled-only-for-the-current

Resolves #714

📝 Summary

CallAccepted events should be handled only for the current user.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Mar 27, 2025
@ipavlidakis ipavlidakis self-assigned this Mar 27, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner March 27, 2025 11:18
@ipavlidakis ipavlidakis mentioned this pull request Mar 27, 2025
Closed
@github-actions
Copy link

Public Interface

🚀 No changes affecting the public interface.

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Mar 27, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.6 MB 7.6 MB 0 KB 🟢
StreamVideoSwiftUI 2.09 MB 2.09 MB 0 KB 🟢
StreamVideoUIKit 2.23 MB 2.23 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the fix/callkit-service-dismisses-notification-wrongly branch from 2263ea5 to f4d4e94 Compare March 27, 2025 16:10
@github-actions
Copy link

Public Interface

🚀 No changes affecting the public interface.

@github-actions
Copy link

Public Interface

🚀 No changes affecting the public interface.

@github-actions
Copy link

Public Interface

🚀 No changes affecting the public interface.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis enabled auto-merge (squash) March 28, 2025 14:38
@ipavlidakis ipavlidakis disabled auto-merge March 28, 2025 14:38
@ipavlidakis ipavlidakis merged commit a654c19 into develop Mar 28, 2025
13 of 14 checks passed
@ipavlidakis ipavlidakis deleted the fix/callkit-service-dismisses-notification-wrongly branch March 28, 2025 14:38
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CallKit ends call when another user accepts

4 participants

@ipavlidakis @Stream-SDK-Bot @martinmitrevski