[Fix]Livestream participants count #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Text(L10n.Call.Livestream.notStarted) | ||
| notStartedView | ||
| } else { | ||
| ZStack { |
There was a problem hiding this comment.
No changes here, just moving things around, right?
There was a problem hiding this comment.
It adds also some background when the state is loading,error or backstage because currently the text just overlays the CallScreen. it also shows the controls show that in any state the user can leave the call.
ipavlidakis
force-pushed
the
fix/livestream-participants-count
branch
from
77b0839 to
f27ea4f
Compare
SDK Size
|
Public Interface🚀 No changes affecting the public interface. |
Public Interface🚀 No changes affecting the public interface. |
Public Interface🚀 No changes affecting the public interface. |
Public Interface🚀 No changes affecting the public interface. |
|
martinmitrevski
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-770/sfu-healthcheck-event-isnt-handled-correctly
🛠 Implementation
The webSocketClient implementation treats the healthCheck events differently. This revision ensures that healthCheck events will go through the regular process that allows all alive observers to receive them.
☑️ Contributor Checklist